Closed IanButterworth closed 2 years ago
Merging #44 (b59d9c9) into master (1e5f746) will increase coverage by
0.08%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 92.79% 92.87% +0.08%
==========================================
Files 5 5
Lines 347 351 +4
==========================================
+ Hits 322 326 +4
Misses 25 25
Impacted Files | Coverage Δ | |
---|---|---|
src/FlameGraphs.jl | 0.00% <0.00%> (ø) |
|
src/graph.jl | 94.33% <100.00%> (+0.22%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1e5f746...b59d9c9. Read the comment docs.
@timholy this should be ready for review now
It works with https://github.com/timholy/ProfileView.jl/pull/176
I'd be happy to merge this, do a patch release, and finish up https://github.com/timholy/ProfileView.jl/pull/176 if you don't have time to review, and are ok with that, @timholy ?
I have a ton of faith in your work, so in the absence of feedback from me, go for it! I haven't yet poked at this, but the plan sounds great!
I've been trying to get ProfileView setup to handle this before claiming victory, but here's WIP over here.
My general strategy is to generate one flamegraph per threadid or all_threads, and stack them in the ProfileView window with some form of combobox selector for
[all, 1, 2, 3, 4 ...]
. As opposed to somehow embedding the thread info into the flamegraph itself and selectively pruning it in the GUI.