search

timholy / Grid.jl

Interpolation and related operations on grids
MIT License
47 stars 26 forks source link

Build fails on 0.2 #23

Closed tomasaschan closed 10 years ago

tomasaschan commented 10 years ago

The latest Travis builds seem to be failing for Julia 0.2, with

ERROR: StepRange not defined

Is StepRange new in 0.3? If so, maybe we should update REQUIRE to match that, and tag a new version (major? minor? at least more significant than bugfix, IMO...).

@timholy

tomasaschan commented 10 years ago

The build failures started with this build, triggered by commit cd4c99d61b70b1c7aaed6c75527cbcfa12dafabd. All subsequent builds fail with the same error message on 0.2 (and pass on 0.3).

cd4c99d61b70b1c7aaed6c75527cbcfa12dafabd does introduce a reference to StepRange, here - and that seems to be the only time StepRange is referenced. Is there some other type we could use instead, that will work under 0.2 as well? If so, we might not have to deprecate support for 0.2 just yet.

On the other hand, with release of 0.3 right around the corner, it might not be worth the effort.

simonbyrne commented 10 years ago

StepRange and other new Range types are also used for CoordInterpGrid. It seems like the REQUIRE file has already been set appropriately, but this doesn't stop travis from running. If you want to change this, you need to edit the .travis.yml file.

tomasaschan commented 10 years ago

Oh, yeah that's right. I remember reading something about that somewhere, now that you mention it. I guess it's just not worth the effort then, since it's going to be a non-issue as soon as 0.3 is officially released.

timholy commented 10 years ago

Yes, I thought about disabling juliareleases in the .travis.yml file, but I was worried I'd forget to reinstate it. But thanks very much for looking into this so carefully.