search

timholy / Grid.jl

Interpolation and related operations on grids
MIT License
47 stars 26 forks source link

Text representation of InterpGrid is confusing #48

Closed CCWRoy closed 9 years ago

CCWRoy commented 9 years ago

The #undef values would really throw off newcomers. I thought something was wrong with my machine, and almost opened an issue.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 57a8f953d4311f794aadb80e561852f4677c5b1b on CCWRoy:patch-1 into e9a8391913a2fd24f22231749adeb6f12954b87c on timholy:master.

tomasaschan commented 9 years ago

This is nice, thank you!

We should probably consider changing the way an InterpGrid displays in the REPL, too, to make this less scary to newbies. However, I've never really grok'ed which of display, show, writemime et al one should extend to do that...

@CCWRoy Do you have any suggestion on how an InterpGrid might better be represented as ASCII?

timholy commented 9 years ago

@CCWRoy, thanks for the contribution! However, there was another fix (see the commit) that simply caused it to work as you might have expected.

timholy commented 9 years ago

(Fix is available if you do Pkg.update().)

CCWRoy commented 9 years ago

@timholy Thanks! Yes, your fix now causes REPL to properly display the values of Grid objects. @tlycken No problem! Although Tim has rendered my pull request obsolete, haha! I like how InterpGrid is represented in ASCII as is in his new commit.

By the way guys, are there any interpolation (non-uniform) packages that you know of in Julia? I did check out the irregular interpolation section of the src folder, but I couldn't them working for some reason. I was in a rush, so I'm using something else for now in my project. If there isn't an active project for non-uniform interpolation, I will see if I can find time to write a basic one.