search

timholy / Grid.jl

Interpolation and related operations on grids
MIT License
47 stars 26 forks source link

Using WoodburyMatrices #56

Closed sglyon closed 9 years ago

sglyon commented 9 years ago

These have been removed from base and (right now) live here

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-20.61%) to 76.51% when pulling 88a4012531d4ff0dd43af8be8c2192ad2fcccfaa on spencerlyon2:patch-1 into 2c7a96ce2563065748f2c5178cdb77e2182bf311 on timholy:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-15.86%) to 81.26% when pulling 88a4012531d4ff0dd43af8be8c2192ad2fcccfaa on spencerlyon2:patch-1 into 2c7a96ce2563065748f2c5178cdb77e2182bf311 on timholy:master.

timholy commented 9 years ago

Thanks!

I'm a little puzzled it passes tests on both 0.3 and 0.4. Would it make more sense, though, to load the package only on 0.4? It looks like 0.4.0-dev+3066 is the version number in which the removal happened.

tomasaschan commented 9 years ago

@timholy Do you want to load the package only on 0.4 before this merges? I don't think there's a problem with loading it on 0.3 as well - there's no require file or anything in WoodburyMatrices that specifies that it's 0.4 only (even though I know the same functionality exists in base).

I'm curious to see if merging this fixes the 0.4 builds on the other PR's, so if you don't want to merge this without that change and @spencerlyon2 doesn't have time for this right now, I might build another PR from this one which only loads the Woodbury package on builds after the specified commit.

sglyon commented 9 years ago

Can we do a check of the Julia version from within REQUIRE?

tomasaschan commented 9 years ago

@spencerlyon2 I don't think that is possible, but I don't see a reason to given that it seems to work fine on 0.3 as well (and the need to is only temporary until 0.4 is released).

@timholy Do you have any objections to me merging this in its current state? I want this in before I merge #57.

tomasaschan commented 9 years ago

@spencerlyon2 I took the liberty of cherry-picking your commits onto a branch of my own, which I merged in #58 - didn't feel like waiting :) Hope you're OK with that.

sglyon commented 9 years ago

Of course, thanks for taking care of it. 

On April 13, 2015 at 6:56:12 AM EDT, Tomas Lycken notifications@github.com wrote:@spencerlyon2 I took the liberty of cherry-picking your commits onto a branch of my own, which I merged in #58 - didn't feel like waiting :) Hope you're OK with that. —Reply to this email directly or view it on GitHub.