search

timholy / Grid.jl

Interpolation and related operations on grids
MIT License
47 stars 26 forks source link

v0.4 tuple vararg syntax #59

Closed sebastiang closed 9 years ago

sebastiang commented 9 years ago

I'm not clear on whether the new Tuple{Vararg{T}} syntax is locked down, but this change at least gets Grid to compile and pass tests. I have to admit I'm not a fan of the Vararg, preferring ellipses, but I know that's been bike-shedded around extensively elsewhere.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 81.26% when pulling 5f75a3cac1f497b74f0741c9345438db31d7eb3b on PalladiumConsulting:sg/tuple into e1a6209b534bc940558d294d6d11a0f2a4c8f347 on timholy:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 81.26% when pulling 5f75a3cac1f497b74f0741c9345438db31d7eb3b on PalladiumConsulting:sg/tuple into e1a6209b534bc940558d294d6d11a0f2a4c8f347 on timholy:master.

tomasaschan commented 9 years ago

LGTM; I'm not a big fan of the syntax either, but we might as well stick with whatever is in Base for now, and then update again if the syntax changes. It might not, after all :)

timholy commented 9 years ago

Thanks for tackling this, @sebastiang!

sebastiang commented 9 years ago

updated the botched translate

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 81.26% when pulling ef7a235f5b707d778faf0a26120390553500f2fc on PalladiumConsulting:sg/tuple into e1a6209b534bc940558d294d6d11a0f2a4c8f347 on timholy:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 81.26% when pulling ef7a235f5b707d778faf0a26120390553500f2fc on PalladiumConsulting:sg/tuple into e1a6209b534bc940558d294d6d11a0f2a4c8f347 on timholy:master.

timholy commented 9 years ago

Thanks!