timholy / IProfile.jl

Profilers for Julia
MIT License
18 stars 15 forks source link

Deprecated Warnings & Type Errors #12

Closed fundamental closed 11 years ago

fundamental commented 11 years ago

I was initially stumped by why the below test case generated an error, so I fixed the warnings emitted and then traced it to a chunk of code which assumed that this expression was a function declaration in disguise.

@iprofile begin a = 2 end

While the fix for the actual problem here was straightforward, the only guarantees I offer on the expr->Expr conversion is that looks right and the included test case functions as expected.

timholy commented 11 years ago

This looks good. Can I ask you to add your test case to test/iprofile.jl?

fundamental commented 11 years ago

Can I ask you to add your test case to test/iprofile.jl?

Done

timholy commented 11 years ago

Many thanks!