search

timholy / MethodAnalysis.jl

Utilities to analyze Julia's method tables
https://timholy.github.io/MethodAnalysis.jl/stable/
MIT License
94 stars 3 forks source link

Don't create methodinstances by looking #18

Closed timholy closed 4 years ago

timholy commented 4 years ago

It turns out that calling which(f, types) can create new MethodInstances that didn't exist before. We need to avoid doing that when looking for them.

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   91.84%   91.78%   -0.06%     
==========================================
  Files           4        4              
  Lines         282      280       -2     
==========================================
- Hits          259      257       -2     
  Misses         23       23
Impacted Files Coverage Δ
src/MethodAnalysis.jl 95.12% <100.00%> (-0.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8af6d04...9a1028e. Read the comment docs.