Fix \approx check for pre-0.5 versions

timholy / PositiveFactorizations.jl

Positive-definite "approximations" to matrices

Other

38 stars 12 forks source link

Fix \approx check for pre-0.5 versions #10

Closed anriseth closed 7 years ago

anriseth commented 7 years ago

Ref @tkelman comment https://github.com/timholy/PositiveFactorizations.jl/pull/9#pullrequestreview-19172409

anriseth commented 7 years ago

Hmm. I don't understand how to fix this. From what I see, \approx was implemented in Julia commit 9ccdbffe, which has VERSION v0.4.0-dev. So @tkelman, what version of the v0.5 pre-releases did you mean that the test in #9 would fail on?

Is it okay to test VERSION < v0.5 instead?

tkelman commented 7 years ago

it might not be the introduction of it, but some later change that made it more capable that you're relying on here

timholy commented 7 years ago

Thanks!