search

timholy / ProgressMeter.jl

Progress meter for long-running computations
MIT License
694 stars 91 forks source link

Performance test fails in 1.7 #219

Closed MarcMush closed 2 months ago

MarcMush commented 3 years ago

The performance test fails on julia-1.7.0-rc1 and ProgressMeter#master (doesn't happen with ProgressMeter 1.7.1)

tested on windows and wsl

(jl_EufnDT) pkg> test ProgressMeter
     Testing ProgressMeter
      Status `/tmp/jl_hQwVQU/Project.toml`
  [92933f4c] ProgressMeter v1.7.1 `https://github.com/timholy/ProgressMeter.jl.git#master`
  [8ba89e20] Distributed `@stdlib/Distributed`
  [b77e0a4c] InteractiveUtils `@stdlib/InteractiveUtils`
  [de0858da] Printf `@stdlib/Printf`
  [9a3f8284] Random `@stdlib/Random`
  [8dfed614] Test `@stdlib/Test`
      Status `/tmp/jl_hQwVQU/Manifest.toml`
  [92933f4c] ProgressMeter v1.7.1 `https://github.com/timholy/ProgressMeter.jl.git#master`
  [2a0f44e3] Base64 `@stdlib/Base64`
  [8ba89e20] Distributed `@stdlib/Distributed`
  [b77e0a4c] InteractiveUtils `@stdlib/InteractiveUtils`
  [56ddb016] Logging `@stdlib/Logging`
  [d6f4376e] Markdown `@stdlib/Markdown`
  [de0858da] Printf `@stdlib/Printf`
  [9a3f8284] Random `@stdlib/Random`
  [9e88b42a] Serialization `@stdlib/Serialization`
  [6462fe0b] Sockets `@stdlib/Sockets`
  [8dfed614] Test `@stdlib/Test`
  [4ec0a83e] Unicode `@stdlib/Unicode`
     Testing Running tests...
  0.092720 seconds (8 allocations: 480 bytes)
  0.012372 seconds
Progress: 100%|███████████████████████████████████████████████| Time: 0:00:00
Core: Test Failed at /home/mittel/.julia/packages/ProgressMeter/jLxQW/test/core.jl:51
  Expression: #= /home/mittel/.julia/packages/ProgressMeter/jLxQW/test/core.jl:51 =# @elapsed(prog_perf(10 ^ 7)) < 9 * #= /home/mittel/.julia/packages/ProgressMeter/jLxQW/test/core.jl:51 =# @elapsed(noprog_perf(10 ^ 7))
   Evaluated: 0.4294283 < 0.1127664
Stacktrace:
 [1] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Test/src/Test.jl:445 [inlined]
 [2] top-level scope
   @ ~/.julia/packages/ProgressMeter/jLxQW/test/core.jl:51
garrison commented 2 years ago

Hmm. The constant factor in this comparison started as 40, which I found not to be high enough to pass on a julia 1.6 prerelease. Later, this constant was lowered to 8, and later it was increased to 9. It seems that all of these changes have made it into ProgressMeter.jl 1.7.1, though. The two commits to master since then do not seem suspicious to me.