Closed Fro116 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5b3bd1d
) 96.81% compared to head (0ca12d5
) 97.03%. Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
My bad, I never tested on older versions of Julia. The Threads.@threads had a different expression tree before v1.3.0-rc1 and so the new test I added was failing on older builds.
I'll gate the Threads.@threads test behind a @static if VERSION >= v"1.3.0-rc1"
statement, the same way we do for some Threads.@spawn tests in test_threads.jl.
Take three. I updated to fix the code coverage errors.
The last run failed on the nightly ubuntu-latest build because the test case "test_threads.jl ProgressUnknown" errored out. I'm not sure why. That test should not touch any of the code in this pr. I can't repro it, and it didn't fail in the first run (https://github.com/timholy/ProgressMeter.jl/actions/runs/6859117251/job/18660114093?pr=284). Is the test flaky on master?
Recently yes Ref #281
Okay, afaict this passes everything except for the flaky test. Should be good to go, but let me know if there's anything else I should look into.
LGTM
This lets you use the @showprogress macro on parallel for loops. For example,