search

timholy / ProgressMeter.jl

Progress meter for long-running computations
MIT License
694 stars 91 forks source link

tests: don't use single-argument `map` #291

Closed nsajko closed 8 months ago

nsajko commented 8 months ago

Single-argument map is being removed from Julia after an analysis of registered packages found that the change doesn't break the functionality of any package. See JuliaLang/julia#35293 and JuliaLang/julia#52631

That said, the Julia change breaks your test suite, so here's a PR that fixes that.

MarcMush commented 8 months ago

broadcast(f) is also tested here, will it be also removed? this whole section can be removed (L168-175)

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5b3bd1d) 96.81% compared to head (3e01878) 96.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ======================================= Coverage 96.81% 96.81% ======================================= Files 1 1 Lines 533 533 ======================================= Hits 516 516 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nsajko commented 8 months ago

broadcast(f) is still supported.