timholy / Revise.jl

Automatically update function definitions in a running Julia session
https://timholy.github.io/Revise.jl/stable
Other
1.21k stars 110 forks source link

Fix `parse_cache_header` signature change #767

Closed serenity4 closed 1 year ago

serenity4 commented 1 year ago

Base.parse_cache_headers removed its keyword srcfiles_only in https://github.com/JuliaLang/julia/pull/49866, which makes Revise non-functional in nightly.

There are a bunch of other test failures, and I'm not sure I understand the internals enough to address them, but I could identify least two sources (there are probably more):

Anyway, we can probably merge this fix and worry about other failures on nightly later, such that Revise works again on nightly. Or if anyone wants to address nightly failures in a wider swath, that works for me too.

Keno commented 1 year ago

@timholy can you take a look at this to unbreak revise?

fatteneder commented 1 year ago

This is my bad, I apologize! I really thought I had opened a PR here but apparently I did not ...

Keno commented 1 year ago

Not your fault. There's a structural issue in our process that this wasn't noticed - we'll need to fix that.