search

timholy / Revise.jl

Automatically update function definitions in a running Julia session
https://timholy.github.io/Revise.jl/stable
Other
1.19k stars 109 forks source link

More 1.12 compat #827

Closed Keno closed 1 month ago

Keno commented 1 month ago

With this and the LCU fixes, Revise should pass tests again on 1.12.

Keno commented 1 month ago

Updated to bump LCU and cherry-pick the additional fixes from #829

KristofferC commented 1 month ago

Interesting that the linux testers don't know about LCU 3.0.1.

Keno commented 1 month ago

Probably just hadn't propagated yet. Rerunning.

Keno commented 1 month ago

@timholy The last issue here is that ExponentialUtilities v1.9.0 is not compatible with all the julia versions we want to test. Can we switch this test to be more self contained and include some minimal in the test code itself rather than depending on some external package?

Keno commented 1 month ago

That's mostly a separate change though. I would propose merging this first and then addressing that last issue.

timholy commented 1 month ago

Can we switch this test to be more self contained and include some minimal in the test code itself rather than depending on some external package?

Yes, that needs to happen. I have been doing that for newer tests, but I haven't migrated old tests. Doesn't need to stand in the way of this PR.