timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Fix SnoopCompileBot #112

Closed aminya closed 4 years ago

aminya commented 4 years ago

Edit: fixed in https://github.com/aminya/SnoopCompileBot.jl/pull/3

We can revert the changes of Project.toml and src/SnoopCompile.jl if you prefer that. Using the workflow_CI, we can see if the package breaks by doing that.

aminya commented 4 years ago

This finally passes the tests https://github.com/JuliaMusic/MusicXML.jl/actions/runs/149958419. This was a cumbersome experience. 😥

This solution is very ugly :unamused:, but that is the only one I could find among all the ones you see in the commit list. Let me know if you know a better trick.

aminya commented 4 years ago

Because of importing conflicts, this breaks the direct use of SnoopCompileBot in the snooping script with using SnoopCompileBot in favor of the old using SnoopCompile.

Because of that, the tests here fail, but that does not matter much. Later in SnoopCompile 2, we can fix this.

For now, we can change the tests to using SnoopCompile, and test the SnoopCompileBot as part of SnoopCompile.

aminya commented 4 years ago

I added workflow_CI, so we have a better idea of what is going on with SnoopCompileBot. This will prevent us from tagging broken versions from now on.

We can revert the changes of Project.toml and src/SnoopCompile.jl if you prefer that. Using the workflow_CI, we can see if it breaks by doing that.

timholy commented 4 years ago

Superseded by #113