search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Version 1.6.2 #113

Closed timholy closed 4 years ago

timholy commented 4 years ago

Fixes the bot on 1.6. Tested against MusicXML v0.3.2. I had to delete the exhausive keywords from the snoop scripts; that was never in a released version of SnoopCompile, so that isn't cheating.

@aminya, one thing I had to do to make it work was execute the instructions in https://github.com/timholy/SnoopCompile.jl/issues/105#issuecomment-649345931 in the MusicXML environment, since the bot launches with --project. Interestingly, I had to manually edit the paths in the resulting MusicXML/Manifest.toml manually: doing the rm SnoopCompileCore ... deleted the path= statement from the Manifest.toml and reverted to the git tree sha.

aminya commented 4 years ago

Fixes the bot on 1.6. Tested against MusicXML v0.3.2. I had to delete the exhausive keywords from the snoop scripts; that was never in a released version of SnoopCompile, so that isn't cheating.

I had fixed the old deprecations on the master branch. But it is not registered it yet.

@aminya, one thing I had to do to make it work was execute the instructions in #105 (comment) in the MusicXML environment, since the bot launches with --project. Interestingly, I had to manually edit the paths in the resulting MusicXML/Manifest.toml manually: doing the rm SnoopCompileCore ... deleted the path= statement from the Manifest.toml and reverted to the git tree sha.

Registration of the package will probably solve this. I bypassed the registration headache by just including SnoopCompileBot directly in SnoopCompile.jl. See its successful run: https://github.com/JuliaMusic/MusicXML.jl/actions/runs/150097985

I think we should merge workflow CI in #114 to check if this works.

timholy commented 4 years ago

Sure, I'd be happy to have the workflow file join this. Let's see if these tests pass and then we can merge that. I'll check in the morning.