timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Slim down to SnoopCompile and SnoopCompileCore #127

Closed timholy closed 4 years ago

timholy commented 4 years ago

This will be version 2.0 of SnoopCompile. It excises the bot, which should move to a separate repository. It also merges SnoopCompileAnalysis back into SnoopCompile itself.

Closes #118 Closes #121 Closes #122 Closes #77 Closes #99 Closes #100 Closes #115

aminya commented 4 years ago

Thanks for this. I will move the repository to my account later this week.

I want to vote against merging Analysis and Core modules. The analysis module compiles parts of code that can make the snooping result inaccurate in some cases. For example, when you want to use SnoopCompile for snooping Pkg or some other core library. These deps can bring a lot of compiled code which decreases the accuracy of snooping for such core packages:

Cthulhu 
OrderedCollections 
timholy commented 4 years ago

Core and "Analysis" are still separate. What I did was basically take Analysis's code and put it in SnoopCompile itself. So you can do all the snooping with SnoopCompileCore, and then just say using SnoopCompile. That gives you what you used to get with SnoopCompileAnalysis.

aminya commented 4 years ago

Core and "Analysis" are still separate. What I did was basically take Analysis's code and put it in SnoopCompile itself. So you can do all the snooping with SnoopCompileCore, and then just say using SnoopCompile. That gives you want you used to get with SnoopCompileAnalysis.

Oh, I see. That would work. 👍

aminya commented 4 years ago

@timholy I want to move SnoopCompileBot to my account, but I have a question. Should I start a fresh git repository or there is a way to keep the git history for certain files?

Edit: the following did the job

git filter-branch -f --tree-filter "rm -rf ./Project.toml ./LICENSE.md ./NEWS.md ./README.md ./SnoopCompileAnalysis ./SnoopCompileCore ./src ./examples ./test ./utils ./docs/* ./docs/src/index.md ./docs/src/reference.md ./docs/src/snoopc.md ./docs/src/snoopi.md ./docs/src/snoopr.md ./docs/src/userimg.md" --prune-empty HEAD