search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Improve selectivity in "deep" invalidations #220

Closed timholy closed 3 years ago

timholy commented 3 years ago

The former implementation collected some "spurious" invalidations: methods in Core (which runs in an old world-age) and precompiled CodeInstances (which get loaded from cache with max_world = 0).

This also returns the full InferenceTimingNodes, which seems useful since it gives a sense of the cost of recompiling it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #220 (aa6b931) into master (86b1e11) will decrease coverage by 0.11%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   80.91%   80.79%   -0.12%     
==========================================
  Files           9        9              
  Lines        1352     1354       +2     
==========================================
  Hits         1094     1094              
- Misses        258      260       +2
Impacted Files Coverage Δ
src/parcel_snoopi_deep.jl 80.51% <90.90%> (-0.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86b1e11...aa6b931. Read the comment docs.