search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Suggest only if the callee matches the trigger #247

Closed timholy closed 3 years ago

timholy commented 3 years ago

The issue here is a call to

hvcat(rows::Tuple{Vararg{Int}}, xs::_DenseConcatGroup...) = Base.typed_hvcat(promote_eltype(xs...), rows, xs...)

which has a couple of Core._apply_iterate and the matching fails when it doesn't match the trigger promote_eltype. I tried to come up with a MWE but failed.

Fixes #244

codecov[bot] commented 3 years ago

Codecov Report

Merging #247 (1b56e3c) into master (c549ba5) will decrease coverage by 0.24%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   85.29%   85.05%   -0.25%     
==========================================
  Files           9        9              
  Lines        1578     1579       +1     
==========================================
- Hits         1346     1343       -3     
- Misses        232      236       +4
Impacted Files Coverage Δ
src/parcel_snoopi_deep.jl 87.61% <100.00%> (-0.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c549ba5...1b56e3c. Read the comment docs.