search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Track invalidations during deserialization #260

Closed timholy closed 3 years ago

timholy commented 3 years ago

These were printed to the console but not otherwise stored. Storing them allows one to give them more emphasis and perform analysis. With https://github.com/JuliaLang/julia/pull/41913, it becomes possible to attribute them to specific method definitions or deletions. (Of course there might be multiple reasons, but we need to identify at least one in order to make progress.)

CC @chriselrod, @vtjnash, @ChrisRackauckas. If anyone plans to try this, until 2.8 is released be sure to dev SnoopCompileCore too as it is a separate (subdir) module and there are changes due to #257.

codecov[bot] commented 3 years ago

Codecov Report

Merging #260 (f683000) into master (40bba9c) will decrease coverage by 1.48%. The diff coverage is 43.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   85.04%   83.55%   -1.49%     
==========================================
  Files          15       15              
  Lines        1745     1800      +55     
==========================================
+ Hits         1484     1504      +20     
- Misses        261      296      +35
Impacted Files Coverage Δ
src/invalidations.jl 79.93% <43.07%> (-8.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40bba9c...f683000. Read the comment docs.

timholy commented 3 years ago

To really be functional in the tests we'll have to wait for JuliaLang/julia#41913 to hit nightly. But since this hasn't broken anything, I'll merge.