Open letalvoj opened 3 years ago
Ok. These should be all Symbol
according to the test suite. I have no idea why I get Expr
there.
The snooped compilation is pretty large and it uses macros, Flux, HTTP, ... 🤷
A workaround which might just produce incorrect results yet it works for what I needed it to was to replace
name = String(name)::String
with
name = string(name)::String
I'd be fine with a PR that does that, especially if it came with a test! I don't know how to trigger this, but if you do...
Yeah, it's most likely wrong for the ::Expr
type ... If I fix it such that it makes sense I'll send a PR for sure 👍
Yeah, I'm hitting this as well when benchmarking code. I can share a private reproducer if you want @timholy
Yeah, I'd take a reproducer!
It's not minimal, but I'll e-mail it.
@pkofod did you manage to find out the root cause?
Hello! Is any thoughts how to fix it locally?
Recommended practice these days is to use SnoopPrecompile. I'd recommend switching.
Julia 1.5.4, SnoopCompile 2.7.1
yields
it's this line
https://github.com/timholy/SnoopCompile.jl/blob/5ad2f249a4c331b50067192f850b01fbd52218d2/src/parcel_snoopc.jl#L89
Seems like there is a test covering that very method. If I manage to fix that issue I will submit a pr
https://github.com/timholy/SnoopCompile.jl/blob/a75d41856849be2d661163bbce184f71f5a3ae8d/test/colortypes.jl#L4