search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Slim precompile files for Julia 1.6+ #276

Closed timholy closed 2 years ago

timholy commented 2 years ago

If a package only supports Julia versions that have Base.bodyfunction, we don't need to define __lookup_kwbody__. However, we can't simply query the running version of Julia, because the precompile file may used by a different Julia version. This adds a manual keyword argument.

codecov[bot] commented 2 years ago

Codecov Report

Merging #276 (e8be2f5) into master (cb12708) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          16       16           
  Lines        2023     2023           
=======================================
  Hits         1759     1759           
  Misses        264      264
Impacted Files Coverage Δ
src/parcel_snoopi.jl 94.14% <100.00%> (ø)
src/parcel_snoopi_deep.jl 89.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb12708...e8be2f5. Read the comment docs.