timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

make SnoopCompile compatible with JET@0.6.0 #281

Closed aviatesk closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #281 (0e6484a) into master (644081f) will decrease coverage by 3.92%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   86.44%   82.52%   -3.93%     
==========================================
  Files          16       16              
  Lines        2022     1917     -105     
==========================================
- Hits         1748     1582     -166     
- Misses        274      335      +61     
Impacted Files Coverage Δ
src/invalidation_and_inference.jl 0.00% <0.00%> (-87.94%) :arrow_down:
SnoopCompileCore/src/snoopi.jl 55.73% <0.00%> (-6.09%) :arrow_down:
src/invalidations.jl 86.11% <0.00%> (-2.38%) :arrow_down:
src/parcel_snoopi_deep.jl 88.21% <0.00%> (-1.35%) :arrow_down:
src/deep_demos.jl 57.89% <0.00%> (-1.08%) :arrow_down:
src/write.jl 91.30% <0.00%> (-1.01%) :arrow_down:
src/parcel_snoopl.jl 89.47% <0.00%> (-0.53%) :arrow_down:
SnoopCompileCore/src/snoopi_deep.jl 91.66% <0.00%> (-0.34%) :arrow_down:
src/parcel_snoopi.jl 93.83% <0.00%> (-0.31%) :arrow_down:
src/visualizations.jl 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 644081f...0e6484a. Read the comment docs.

aviatesk commented 2 years ago

The failures in nightly seems to come from the changes on Julia Base from https://github.com/JuliaLang/julia/pull/45069. The integration with JET runs successfully.

timholy commented 2 years ago

Thanks so much!