timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Implement more powerful tree-join, fix tests on Julia-1.8 #292

Closed timholy closed 2 years ago

timholy commented 2 years ago

Julia-1.8 reports invalidations slightly differently from previous versions. This harmonizes the output and avoids duplicating trees/roots/branches.

While this suffices to fix SnoopCompile on 1.8, nightly will require additional work (failure anticipated).

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.24% // Head: 86.03% // Increases project coverage by +5.78% :tada:

Coverage data is based on head (365f218) compared to base (ccbafd6). Patch coverage: 72.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #292 +/- ## ========================================== + Coverage 80.24% 86.03% +5.78% ========================================== Files 17 17 Lines 1929 2098 +169 ========================================== + Hits 1548 1805 +257 + Misses 381 293 -88 ``` | [Impacted Files](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | Coverage Δ | | |---|---|---| | [src/invalidations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2ludmFsaWRhdGlvbnMuamw=) | `86.71% <72.50%> (+9.53%)` | :arrow_up: | | [SnoopCompileCore/src/snoopi\_deep.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-U25vb3BDb21waWxlQ29yZS9zcmMvc25vb3BpX2RlZXAuamw=) | `92.00% <0.00%> (-3.66%)` | :arrow_down: | | [SnoopPrecompile/src/SnoopPrecompile.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-U25vb3BQcmVjb21waWxlL3NyYy9Tbm9vcFByZWNvbXBpbGUuamw=) | `81.25% <0.00%> (-0.90%)` | :arrow_down: | | [src/parcel\_snoopc.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGMuamw=) | `78.15% <0.00%> (-0.23%)` | :arrow_down: | | [src/visualizations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3Zpc3VhbGl6YXRpb25zLmps) | `0.00% <0.00%> (ø)` | | | [src/parcel\_snoopi.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGkuamw=) | `94.14% <0.00%> (+0.30%)` | :arrow_up: | | [src/parcel\_snoopl.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGwuamw=) | `90.00% <0.00%> (+0.52%)` | :arrow_up: | | [src/write.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3dyaXRlLmps) | `92.30% <0.00%> (+1.00%)` | :arrow_up: | | [src/deep\_demos.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2RlZXBfZGVtb3Muamw=) | `58.97% <0.00%> (+1.07%)` | :arrow_up: | | [src/parcel\_snoopi\_deep.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGlfZGVlcC5qbA==) | `89.98% <0.00%> (+3.23%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/292/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.