search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Get package working on 1.9 #293

Closed timholy closed 2 years ago

timholy commented 2 years ago

Adapts to changes in how methods are printed, details on how inference works, and in how invalidations are recorded.

codecov[bot] commented 2 years ago

Codecov Report

Base: 86.03% // Head: 85.91% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (209f288) compared to base (e87fbe7). Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #293 +/- ## ========================================== - Coverage 86.03% 85.91% -0.12% ========================================== Files 17 17 Lines 2098 2102 +4 ========================================== + Hits 1805 1806 +1 - Misses 293 296 +3 ``` | [Impacted Files](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | Coverage Δ | | |---|---|---| | [src/invalidations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2ludmFsaWRhdGlvbnMuamw=) | `86.14% <25.00%> (-0.58%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timholy commented 2 years ago

The test failure is in the JET integration tests, and locally this works on the master branch of JET. Pinging @aviatesk for a possible new release? No urgency, though, I'll merge and tag this after one more PR.