timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Update invalidation logging format #306

Closed timholy closed 1 year ago

timholy commented 1 year ago

This updates to the logging format used by the most recent nightly build of Julia (1.9). While there has been a lot of churn in this area, there are reasons to hope that we're entering a period of stability: there are no known "holes" in our coverage after resolving the invoke issues (https://github.com/JuliaLang/julia/pull/46010 and fixup PRs that came later), and the subsequent major rewrite of the invalidation logic (https://github.com/JuliaLang/julia/pull/46920) suggests this format may have some durability.

CC @vtjnash

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.14% // Head: 85.47% // Decreases project coverage by -0.66% :warning:

Coverage data is based on head (bb38509) compared to base (f4d9a7b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #306 +/- ## ========================================== - Coverage 86.14% 85.47% -0.67% ========================================== Files 17 17 Lines 2129 2162 +33 ========================================== + Hits 1834 1848 +14 - Misses 295 314 +19 ``` | [Impacted Files](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | Coverage Δ | | |---|---|---| | [src/invalidations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/306/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2ludmFsaWRhdGlvbnMuamw=) | `83.91% <100.00%> (-2.99%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.