timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Clear backedge_table less eagerly #329

Closed timholy closed 1 year ago

timholy commented 1 year ago

We only need to clear the table between packges, and only the integer keys are ambiguous.

Fixes the bug reported on discourse

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.14% // Head: 83.56% // Increases project coverage by +6.42% :tada:

Coverage data is based on head (97a4b35) compared to base (38c9cba). Patch coverage: 56.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #329 +/- ## ========================================== + Coverage 77.14% 83.56% +6.42% ========================================== Files 17 17 Lines 2021 2178 +157 ========================================== + Hits 1559 1820 +261 + Misses 462 358 -104 ``` | [Impacted Files](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | Coverage Δ | | |---|---|---| | [src/invalidations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2ludmFsaWRhdGlvbnMuamw=) | `73.65% <56.25%> (+9.75%)` | :arrow_up: | | [src/parcel\_snoopc.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGMuamw=) | `78.15% <0.00%> (-0.23%)` | :arrow_down: | | [src/SnoopCompile.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL1Nub29wQ29tcGlsZS5qbA==) | `100.00% <0.00%> (ø)` | | | [src/visualizations.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3Zpc3VhbGl6YXRpb25zLmps) | `0.00% <0.00%> (ø)` | | | [src/parcel\_snoopl.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGwuamw=) | `90.00% <0.00%> (+0.52%)` | :arrow_up: | | [src/deep\_demos.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL2RlZXBfZGVtb3Muamw=) | `58.97% <0.00%> (+1.07%)` | :arrow_up: | | [src/parcel\_snoopi.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGkuamw=) | `95.00% <0.00%> (+1.16%)` | :arrow_up: | | [src/write.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3dyaXRlLmps) | `92.30% <0.00%> (+1.39%)` | :arrow_up: | | [src/parcel\_snoopi\_deep.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-c3JjL3BhcmNlbF9zbm9vcGlfZGVlcC5qbA==) | `90.01% <0.00%> (+3.45%)` | :arrow_up: | | [SnoopCompileCore/src/snoopi\_deep.jl](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy#diff-U25vb3BDb21waWxlQ29yZS9zcmMvc25vb3BpX2RlZXAuamw=) | `100.00% <0.00%> (+4.34%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/timholy/SnoopCompile.jl/pull/329/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tim+Holy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.