search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Turn Cthulhu and JET into weakdeps #376

Closed mkitti closed 5 months ago

mkitti commented 7 months ago

Create CthulhuExt and JETExt extension packages

Cthulhu.jl and JET.jl are rather large and complicated dependencies.

By making them weak dependencies, we increase the likelihood that SnoopCompile.jl could be loaded on development branches of Julia.

At the time of this writing, SnoopCompile.jl cannot be loaded on the Julia 1.11 branch due to an issue with Cthulhu precompilation.

aviatesk commented 6 months ago

Thanks for your PR, @mkitti , and sorry for being late to response! Unfortunately, this seems to be broken on Julia versions earlier than 1.8 (pre pkg extensions), so I'd like to go with #379 first. I'd appreciate if we can merge the change to make Cthulhu integration lazy from this PR though. Do you want to update this PR, or want me to work on that?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.09%. Comparing base (622b233) to head (e98670a). Report is 1 commits behind head on master.

Files Patch % Lines
src/parcel_snoopi_deep.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== + Coverage 78.96% 84.09% +5.12% ========================================== Files 17 17 Lines 2054 2163 +109 ========================================== + Hits 1622 1819 +197 + Misses 432 344 -88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mkitti commented 5 months ago

Closing to rebase and refactor