search

timholy / SnoopCompile.jl

Provide insights about latency (TTFX) for Julia packages
https://timholy.github.io/SnoopCompile.jl/dev/
Other
309 stars 48 forks source link

Version 1.5 #86

Closed timholy closed 4 years ago

timholy commented 4 years ago

Submitted as a PR just to make sure all the CI works properly.

aminya commented 4 years ago

It would be nice if we merge #87 before registration.

timholy commented 4 years ago

Agreed, let's wait for it.

timholy commented 4 years ago

Looks like there's a path issue on Windows, though (\\ vs /).

aminya commented 4 years ago

Oh! I added that test recently. Let me apply some GoodPath on it.

timholy commented 4 years ago

Assuming this passes, do you approve?

timholy commented 4 years ago

Looks like there's still

pathof_noload: Test Failed at D:\a\SnoopCompile.jl\SnoopCompile.jl\test\bot\botutils.jl:5
  Expression: p == pnl
   Evaluated: "C:\\Users\\runneradmin\\.julia\\packages\\MatLang\\TbsCI\\src\\MatLang.jl" == "C:/Users/runneradmin/.julia/packages/MatLang/TbsCI/src/MatLang.jl"
Stacktrace:
 [1] top-level scope at D:\a\SnoopCompile.jl\SnoopCompile.jl\test\bot\botutils.jl:5
 [2] top-level scope at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.2\Test\src\Test.jl:1113
 [3] top-level scope at D:\a\SnoopCompile.jl\SnoopCompile.jl\test\bot\botutils.jl:2

Is this likely outdated? I am not certain that closing and reopening reruns all tests.

timholy commented 4 years ago

Ah, I found a "rerun all jobs button, let's see what happens."

aminya commented 4 years ago

Did you merge master into this branch?

timholy commented 4 years ago

Oh, I see, the failures were specifically for push and not pull_request. Yes, I bet it's fixed.