Implementing Threat

[jokal2]

I see this is on your v0.6 roadmap planning, but getting this started doesn't look too complicated. It seems like we would just need to add threat to

• statistics
• CharacterStats modifiers -- #140
• Aura modifers per class - #141 and #142 for Warriors
• Innate threat -- e.g. as a starting point in #143
• when damage is applied we'd need to also apply threat based on the CharacterStats threat modifier
• when skills with innate threat are activated we'd also need to append threat

I think with the core there we would have functionality to printf("%f", threat_per_second). Polishing it would require:

• rotation support for more specs that care more about threat
• GUI statistics display
• enchants/items with threat modifications

[timhul]

I'm fine with adding at least the groundwork for a GUI representation so we can move towards a full implementation.

As for the GUI representation there are plenty of things I would like to do, that may or may not work visually so it's a bit of a prototyping there that's necessary.

Overall there should probably be another dropdown at the top that lists the roles that are of interest to the user:

• Damage (default)
• Tank
• Healer (omitted for now, but should be availble for the future).

Tank View

QuickSim TPS

In the Tank "view" I'd like the QuickSim result button (which is the one to the top-right to also display TPS (if it fits, again see my comment regarding what may not work visually above).

Threat Breakdown in Statistics

At least during "TankView" (maybe always?) should also have an "Ability Threat Breakdown" or such.

Further Work

Selecting a Tank role with the dropdown functionality enables the future implementation of tank-specific things such as:

Boss Selection for Incoming Damage

It should also make available boss selection for incoming damage modelling (another large area of work). Something like this list is expected:

• None (no incoming damage, e.g. offtank duty)
• Patchwerk
• Broodlord
• Nefarian
• [Suitable AoE pack]
• etc..

Boss Rotations (back-end)

Depending on the selected boss there should be rotations available for each of them so they accurately casts their abilities.

Conclusion

There are lots more things that are of interest, so for the GUI representation it is important to keep this in mind, hence the current "requires further breakdown" label. Implementing some of the fundamental backend things as this issue suggests is a good start.

[jokal2]

The GUI stuff is completely out of my element, I'm perfectly content with whatever you intend to do there.

I figure my next few steps are

• Shield Slam
• Revenge (simply ignoring the parry/dodge/block requirement for now)
• Add a full prot rotation
• Add a fury prot rotation
• Add threat to damage
• Add threat counting to whatever file damage counting is implemented
• Do a pass on any missing innate threat skills
• Implement defiance

[timhul]

Sounds reasonable. Revenge should have an internal buff like Overpower does. The initial implementation should consider also implementing it this way except with the buff always being active. Then it's only a matter of changing what activates the buff in the future.

Adding generic threat to damage will likely require particular design concern.

[jokal2]

Left to do:

• Add always available Revenge
• Merge FuryProt & Prot Rotations
• Add innate threat to more skills
  • Figure out execute 1.25x threat modifier
• Add incoming damage for the purpose of rage generation (note, this first step would be independent of actually tracking incoming damage)
• Add blocking
• Have Revenge available after dodge/block/parry
• Add shield block (for the purpose of modeling the rage expenditure)
• Add shield specialization
• Add toughness
• Add anticipation
• Add one-hand weapon specialization
• Add improved bloodrage