search

timhul / ClassicSim

An event-driven simulation tool written in C++ for World of Warcraft Classic.
Other
116 stars 70 forks source link

BloodFang Armor missing 8/8 bonus #164

Open stupidboy opened 4 years ago

stupidboy commented 4 years ago

SetBonusControl::equip_item only have 3/8 bouns effect for bloodFang armor pls fix it, ths alot

timhul commented 4 years ago

It was previously omitted due to the unknown proc rate of 8/8. If someone can provide the approximate proc rate it's easy to add.

guymanthethird commented 4 years ago

If we can get this information, how should we record/deliver this data to you?

timhul commented 4 years ago

Just to get a baseline implemented all I need is an approximate from initial testing, and from what I've heard it's around 1-2%. For future refinement I'd like the consensus from the expert rogue community, but that's not the point we are at right now.

iShares87 commented 4 years ago

This has a 5% chance to cast upon a succesful melee attack. Please add this =(

guymanthethird commented 4 years ago

Here are logs I made hitting gordok spirits for a few hours. I did the tests similar to the crusader proc tests. One test with 1.8 weapon speed swords (14,818 autos with 409 BF procs and 474 crusader procs), and one test with 2.6/2.8 speed weapons (5,699 autos with 236 BF procs and 273 crusader procs). Only auto attacking. Both yielded a PPM rate of ~0.92. As with the previous set of crusader proc tests, these indicate that the crusader PPM rate is a bit over 1PPM (1.06PPM).

WoWCombatLog_1p8_MH_1p8_OH_part2.txt WoWCombatLog_2p8_MH_2p6_OH_part2.txt