search

timhul / ClassicSim

An event-driven simulation tool written in C++ for World of Warcraft Classic.
Other
116 stars 70 forks source link

How about Simplified Chinese version？ #304

Open developforapple opened 4 years ago

developforapple commented 4 years ago

Hello guys! I plan to translate the ClassicSim into simplified Chinese, and I'm almost done! You can see it in https://github.com/developforapple/ClassicSim/tree/zh_cn

My native language is Chinese, so the translation itself is not difficult. Talents, spells, buff, and so on are translated from the database. But there are still a lot of changes at the code level, some of them are breaking. For example, I added zh and en tags to the XML file. So I don't know if I should pull a request to the repository, or create a new branch, or continue maintenance in my repository. What should I do next? I'd like to ask the big shots for advice.
buff 天赋 装备

@jokal2 @timhul

jokal2 commented 4 years ago

I definitely think it's a great idea to support i18n. Feel free to start putting up PRs that introduce the changes necessary. I see you have 44 commits. Reviewing it all at once would be rather overwhelming, so definitely split it up into logical chunks. We also have a Discord if you'd like to share your ideas there.