search

timhul / ClassicSim

An event-driven simulation tool written in C++ for World of Warcraft Classic.
Other
117 stars 70 forks source link

Thunderfury DPS is incorrect #344

Open Thraga93 opened 3 years ago

Thraga93 commented 3 years ago

It seems as though the 16-30 nature damage component was omitted, resulting in a DPS of 41.8 as opposed to 53.9 as it is in classic.

ShenNan0827 commented 3 years ago

According to #151, ClassicSim modelled the extra nature white damage as a 100% proc rate nature effect.

Also refers to a recent Blizzard blue post [https://www.wowhead.com/news=316707/blizzard-clarifies-that-extra-elemental-damage-from-weapons-is-working-as-intend], Thunderfury "do not actually cause additional non-physical damage to the target". The wording is quite ambiguous. My understanding is that, for skills that are related to weapon DPH like Heroical Strike and whirlwind, the base damage shall include this nature effect. I'm not sure if the current modeling method "a 100% proc rate nature effect" would modeled this accurately.

I'm not a coding person so I can't figure it out myself. Hope my thoughts above could be of a little value to the coding update.