timiditi / pe

0 stars 0 forks source link

Entering empty input after clear command prompt does not abort clear command #4

Open timiditi opened 2 years ago

timiditi commented 2 years ago

In the UG and software, it is stated that after the clear command is input, entering any input other than clear will cancel/abort the command. This is not the case if the user tries to enter an empty input.

To replicate:

  1. input clear command and press enter.

image.png

  1. Confirmation prompt is shown.

image.png

  1. Press enter with an empty input.

image.png

Expected: Clear command is aborted as stated in UG and in the confirmation prompt.

Actual: The clear command is not aborted and the confirmation prompt remains.

nus-pe-bot commented 2 years ago

Team's Response

Hi there,

We note the observation, but we also feel that it should be obvious to the user that hitting the enter key without keying in anything does not count as inputting something in AniList.

To illustrate this, say that the user uses list to list all animes and the feedback message "XX anime(s) listed" is displayed. Following this, the user can hit enter without keying in anything but this feedback message continues to stay on screen. Were this "empty input" to be an actual input, it would be natural to see that the previous feedback message would disappear. Hence, if we went with the implementation where clicking enter with no input aborts the clear command, its behavior would introduce inconsistency.

One may also argue that we could have clarified what counts as an input in the UG, but we are of the view that it would be strange to include this rather irrelevant detail, since users can easily see so for themselves. Hence this is not a bug, but a feature.

Best Regards!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with outright rejecting this bug, as it is a strong, unfounded assumption that all users would think that an empty input is not a valid one, given the prompt shown to them.

The instruction given on the confirmation prompt explicitly and specifically states

Enter 'clear' again to proceed and otherwise to abort.

It is reasonable for any user to interpret this prompt as such:

  1. Entering clear proceeds with the clearing.
  2. Doing anything else (read: "otherwise"), as long as it is not entering clear, which could include entering a blank input, would abort the clearing.

This is also why the analogy with the list command is not an exact match, since there is no indication to the user in that scenario that the programme is expecting a response in the form of entering anything, and the user would not think of it as such.

This bug was reported with a Low Severity due to the fact that while users may eventually deduce that entering an empty input is invalid after trying to do so, it is entirely possible that it is not their first assumption, given the statements in both the prompt in the programme and the UG. Hence, though it does not render the programme unusable, it has the possibility to cause a slight hindrance/momentary confusion to a subset of users, which fits the criteria of a Severity.Low bug.

This could be fixed either by fixing the functionality or, as you stated, updating the in-programme prompt and documentation. Regardless, there is a mismatch between what the program explicitly states it can do and what it actually does.