search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-19438] unique Jenkins ball icons #10543

Closed timja closed 10 years ago

timja commented 10 years ago

We want to be able to show builds as aborted, disabled and never built using the job icons. However in the current version they all use the grey icon.

Originally reported by hanabishi, imported from: unique Jenkins ball icons
  • status: Resolved
  • priority: Minor
  • resolution: Fixed
  • resolved: 2013-10-27T18:53:38+00:00
  • imported: 2022/01/10
timja commented 10 years ago

hanabishi:

https://github.com/jenkinsci/jenkins/pull/931

timja commented 10 years ago

scm_issue_link:

Code changed in jenkins
User: Marcus Jacobsson
Path:
core/src/main/java/hudson/model/BallColor.java
war/src/main/webapp/images/16x16/aborted.gif
war/src/main/webapp/images/16x16/aborted.png
war/src/main/webapp/images/16x16/aborted_anime.gif
war/src/main/webapp/images/16x16/disabled.gif
war/src/main/webapp/images/16x16/disabled.png
war/src/main/webapp/images/16x16/disabled_anime.gif
war/src/main/webapp/images/16x16/nobuilt.gif
war/src/main/webapp/images/16x16/nobuilt.png
war/src/main/webapp/images/16x16/nobuilt_anime.gif
war/src/main/webapp/images/24x24/aborted.gif
war/src/main/webapp/images/24x24/aborted.png
war/src/main/webapp/images/24x24/aborted_anime.gif
war/src/main/webapp/images/24x24/disabled.gif
war/src/main/webapp/images/24x24/disabled.png
war/src/main/webapp/images/24x24/disabled_anime.gif
war/src/main/webapp/images/24x24/nobuilt.gif
war/src/main/webapp/images/24x24/nobuilt.png
war/src/main/webapp/images/24x24/nobuilt_anime.gif
war/src/main/webapp/images/32x32/aborted.gif
war/src/main/webapp/images/32x32/aborted.png
war/src/main/webapp/images/32x32/aborted_anime.gif
war/src/main/webapp/images/32x32/disabled.gif
war/src/main/webapp/images/32x32/disabled.png
war/src/main/webapp/images/32x32/disabled_anime.gif
war/src/main/webapp/images/32x32/nobuilt.gif
war/src/main/webapp/images/32x32/nobuilt.png
war/src/main/webapp/images/32x32/nobuilt_anime.gif
war/src/main/webapp/images/48x48/aborted.gif
war/src/main/webapp/images/48x48/aborted.png
war/src/main/webapp/images/48x48/aborted_anime.gif
war/src/main/webapp/images/48x48/disabled.gif
war/src/main/webapp/images/48x48/disabled.png
war/src/main/webapp/images/48x48/disabled_anime.gif
war/src/main/webapp/images/48x48/nobuilt.gif
war/src/main/webapp/images/48x48/nobuilt.png
war/src/main/webapp/images/48x48/nobuilt_anime.gif
http://jenkins-ci.org/commit/jenkins/975dcadca1d1c4d628532024b77cd2e9a82ef9ad
Log:
[FIXED JENKINS-19438]

Changed so that each nobuilt, aborted and disabled will use icons with unique names. The Icons used in this patch are just a copy of grey.

timja commented 10 years ago

scm_issue_link:

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
core/src/main/java/hudson/model/BallColor.java
war/src/main/webapp/images/16x16/aborted.gif
war/src/main/webapp/images/16x16/aborted.png
war/src/main/webapp/images/16x16/aborted_anime.gif
war/src/main/webapp/images/16x16/disabled.gif
war/src/main/webapp/images/16x16/disabled.png
war/src/main/webapp/images/16x16/disabled_anime.gif
war/src/main/webapp/images/16x16/nobuilt.gif
war/src/main/webapp/images/16x16/nobuilt.png
war/src/main/webapp/images/16x16/nobuilt_anime.gif
war/src/main/webapp/images/24x24/aborted.gif
war/src/main/webapp/images/24x24/aborted.png
war/src/main/webapp/images/24x24/aborted_anime.gif
war/src/main/webapp/images/24x24/disabled.gif
war/src/main/webapp/images/24x24/disabled.png
war/src/main/webapp/images/24x24/disabled_anime.gif
war/src/main/webapp/images/24x24/nobuilt.gif
war/src/main/webapp/images/24x24/nobuilt.png
war/src/main/webapp/images/24x24/nobuilt_anime.gif
war/src/main/webapp/images/32x32/aborted.gif
war/src/main/webapp/images/32x32/aborted.png
war/src/main/webapp/images/32x32/aborted_anime.gif
war/src/main/webapp/images/32x32/disabled.gif
war/src/main/webapp/images/32x32/disabled.png
war/src/main/webapp/images/32x32/disabled_anime.gif
war/src/main/webapp/images/32x32/nobuilt.gif
war/src/main/webapp/images/32x32/nobuilt.png
war/src/main/webapp/images/32x32/nobuilt_anime.gif
war/src/main/webapp/images/48x48/aborted.gif
war/src/main/webapp/images/48x48/aborted.png
war/src/main/webapp/images/48x48/aborted_anime.gif
war/src/main/webapp/images/48x48/disabled.gif
war/src/main/webapp/images/48x48/disabled.png
war/src/main/webapp/images/48x48/disabled_anime.gif
war/src/main/webapp/images/48x48/nobuilt.gif
war/src/main/webapp/images/48x48/nobuilt.png
war/src/main/webapp/images/48x48/nobuilt_anime.gif
http://jenkins-ci.org/commit/jenkins/04195b653bfddaf0b86f2b413fde0464ea8f7708
Log:
JENKINS-19438

Merged pull request #931.

timja commented 10 years ago

dogfood:

Integrated in jenkins_main_trunk #2988
[FIXED JENKINS-19438] (Revision 975dcadca1d1c4d628532024b77cd2e9a82ef9ad)

Result = SUCCESS
kohsuke : 975dcadca1d1c4d628532024b77cd2e9a82ef9ad
Files :