timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-20161] NPE from RunParameterDefinition.getDefaultParameterValue getting /job/{jobname}/api/python w/ "run" parameter for nonexistent project #10691

Open timja opened 10 years ago

timja commented 10 years ago

When I have a run param that uses a project that does not exist, the api throws a 500 error. The UI has no problem requesting the job, loading the job config page, and letting me configure. Its only via the api/python that this happens.

I get the below trace. If I remove the run param, or change it to an existent project, this doesn't happen. This probably shouldn't 500, but maybe throw a warning if anything.

Below I created a project job1 that uses job3 as a run param. Then deleted job3.

~ $ curl -v http://162.243.140.39:8080/job/job1/api/python/

I add job3, and all good.

~ $ curl -v http://162.243.140.39:8080/job/job1/api/python/


Originally reported by makewhatis, imported from: NPE from RunParameterDefinition.getDefaultParameterValue getting /job/{jobname}/api/python w/ "run" parameter for nonexistent project
  • status: Open
  • priority: Major
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 7 years ago

lfielke:

I'm also seeing this issue on Jenkins 2.32.3. Creating a new free style job, adding a run parameter and typing a non-existent job name in the job name field can also trigger this.

The JSON and XML API URLs also error and show similar stacktraces. The stacktrace from the XML one:

java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:335)
    at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:175)
    at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:108)
    at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:124)
    at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.MetaClass$3.doDispatch(MetaClass.java:197)
    at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.MetaClass$5.doDispatch(MetaClass.java:236)
    at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.MetaClass$5.doDispatch(MetaClass.java:236)
    at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
    at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
    at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135)
    at org.jenkinsci.plugins.ssegateway.Endpoint$SSEListenChannelFilter.doFilter(Endpoint.java:225)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at io.jenkins.blueocean.ResourceCacheControl.doFilter(ResourceCacheControl.java:134)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at jenkins.metrics.impl.MetricsFilter.doFilter(MetricsFilter.java:125)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:126)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:86)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
    at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
    at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
    at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
    at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:553)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
    at org.eclipse.jetty.server.Server.handle(Server.java:499)
    at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
    at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
    at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
    at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Failed to write defaultParameterValue
    at org.kohsuke.stapler.export.Property.safeGetValue(Property.java:151)
    at org.kohsuke.stapler.export.Property.writeTo(Property.java:126)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:227)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:279)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:222)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:168)
    at org.kohsuke.stapler.export.Property.writeTo(Property.java:139)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:227)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:279)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:222)
    at org.kohsuke.stapler.export.Property.writeValue(Property.java:168)
    at org.kohsuke.stapler.export.Property.writeTo(Property.java:139)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:227)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeNestedObjectTo(Model.java:223)
    at org.kohsuke.stapler.export.Model.writeTo(Model.java:198)
    at org.kohsuke.stapler.ResponseImpl.writeOne(ResponseImpl.java:285)
    at org.kohsuke.stapler.ResponseImpl.serveExposedBean(ResponseImpl.java:276)
    at hudson.model.Api.doXml(Api.java:100)
    ... 82 more
Caused by: java.lang.reflect.InvocationTargetException
    at sun.reflect.GeneratedMethodAccessor274.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.kohsuke.stapler.export.MethodProperty.getValue(MethodProperty.java:66)
    at org.kohsuke.stapler.export.Property.safeGetValue(Property.java:145)
    ... 105 more
Caused by: java.lang.NullPointerException
    at hudson.model.RunParameterDefinition.getDefaultParameterValue(RunParameterDefinition.java:180)
    ... 110 more

 

timja commented 7 years ago

danielbeck:

vivek jglick I wonder whether https://github.com/stapler/stapler/pull/106 would (allow to) fix this?

timja commented 7 years ago

jglick:

No this is simply a bug in RunParameterDefinition.