timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-64072] Configure UI completely broken after upgrade to 2.264 #1275

Closed timja closed 2 years ago

timja commented 3 years ago

Report all issues with a complete plugin list, and a screenshot

JENKINS_HOST=username:password@myhost.com:port
curl -sSL "http://$JENKINS_HOST/pluginManager/api/xml?depth=1&xpath=/*/*/shortName|/*/*/version&wrapper=plugins" | perl -pe 's/.*?([\w-]+).*?([^<]+)()(<\/\w+>)+/\1 \2\n/g'|sed 's/ /:/'
 

Check if your plugin already has an issue reported https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741 artifactory is https://github.com/jfrog/jenkins-artifactory-plugin/issues/350

If you know which plugin is causing the issue report a new issue, including steps to reproduce and screenshots and label it with 'tables-to-divs-regression'

How to identify which plugin is causing the issue

1. check plugins list against open issues on https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741
2. then if no open issue matches:

How to triage someone else's issue

1. check plugins list against open issues on https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741
2. then if no open issue matches:

curl https://issues.jenkins.io/secure/attachment/53350/53350_jenkins-basith-16112020.txt | sort > abdul-bas-plugins.txt
cat abdul-bas-plugins.txt | cut -d ':' -f 1 | sort > plugins.filtered.txt # remove versions as CLI complains when old versions are there
wget https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/2.1.2/jenkins-plugin-manager-2.1.2.jar
wget https://get.jenkins.io/war/2.266/jenkins.war
export JENKINS_HOME=~/.jenkins-64072
java -jar jenkins-plugin-manager-2.1.2.jar -f abdul-bas-plugins.txt -d ~/.jenkins-64072/plugins --war jenkins.war
java -jar jenkins.war

original text

After upgrade to 2.264.1 via yum package, the confgure UI of all my projects was borked, showing things that the project didn't support, preventing modification and updates to jobs.  Jobs were still running correctly however.  Looking at JavaScript console there were alot of errors in js files.  console log attached.  

 

Fixed by downgrading to 2.263.1 via yum downgrade and temporarily locking the version.  While the UI appears better in 2.263.1, some boxes are still long and an error is still received in the console:

 

hudson-behavior.js:2982 Uncaught SyntaxError: Unexpected token ')'
 at onSuccess (combobox.js:19)
 at klass.respondToReadyState (prototype.js:1657)
 at klass.onStateChange (prototype.js:1600)
 at XMLHttpRequest. (prototype.js:414)

 


Originally reported by jonl_percsol, imported from: Configure UI completely broken after upgrade to 2.264
  • status: Closed
  • priority: Blocker
  • resolution: Fixed
  • resolved: 2022-06-12T14:10:49+00:00
  • imported: 2022/01/10
timja commented 3 years ago

timja:

Boris that is a very different issue please move the discussion on that to a new one

timja commented 3 years ago

timja:

Hi rossc

Can you please test this pre-release version of postbuild-task:

https://repo.jenkins-ci.org/incrementals/org/jvnet/hudson/plugins/postbuild-task/1.9-rc62.454e8cf3c106/postbuild-task-1.9-rc62.454e8cf3c106.hpi

the issue for that plugin is: JENKINS-64088, there appears to be no maintainer.

I requested commit access in https://groups.google.com/g/jenkinsci-dev/c/08iLU7F8RfQ/m/pqrbtqp2AwAJ
(there's a two week timeout and if no response I'll get it)

timja commented 3 years ago

JIRAUSER130069:

In my case it was the old Perforce Plugin (not the P4 one) that broke the job configuration page.

timja commented 3 years ago

JIRAUSER130055:

timja this version fixed one of my jobs (incidentally, the one that uses copyartifact), but not most of them unfortunately.. the visual appearance has changed, so I believe this was a fix and there are additional issues elsewhere.  The job configuration page now looks like below - there is no longer the gray box around the configuration items that gets "broken out of" so to speak.  

 

 

timja commented 3 years ago

timja:

That looks like the plot plugin there’s a separate issue for that one, I’ll link it to this after I find it

timja commented 3 years ago

brababus:

The same issue is on my side, centos, Jenkins v.263->v.264 - cannot save/edit some job configurations, reverted to 263.

timja commented 3 years ago

timja:

brababus please provide a full plugins list

JENKINS_HOST=username:password@myhost.com:port
curl -sSL "http://$JENKINS_HOST/pluginManager/api/xml?depth=1&xpath=/*/*/shortName|/*/*/version&wrapper=plugins" | perl -pe 's/.*?([\w-]+).*?([^<]+)()(<\/\w+>)+/\1 \2\n/g'|sed 's/ /:/'
timja commented 3 years ago

JIRAUSER130055:

I uninstalled plot for now, and can configure all my jobs again - many thanks for all your hard work on this timja it is very much appreciated!

timja commented 3 years ago

timja:

Postbuild task plugin fixed in https://github.com/jenkinsci/postbuild-task-plugin/releases/tag/postbuild-task-1.9

timja commented 3 years ago

basith:

jenkins-basith-16112020.txt

timja Removed artifactory plugins and issue remains the same, I double checked no plot plugin as well. Could you please check and let me know if there is any other plugin causing the issue.

 

timja commented 3 years ago

cryptomatt:

Similar issue with me. No artifactory or plot plugins. latest branch api and jenkins core. timja any thoughts?

plugins.txt

timja commented 3 years ago

timja:

cryptomatt your plugins list says you're not on the latest branch-api?

Could you please include a screenshot too and say which page it is on

timja commented 3 years ago

timja:

basith you have a lot of plugins :O 323.

You can setup a test environment with:

curl https://issues.jenkins.io/secure/attachment/53350/53350_jenkins-basith-16112020.txt | sort > abdul-bas-plugins.txt
wget https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/2.1.2/jenkins-plugin-manager-2.1.2.jar
wget https://get.jenkins.io/war/2.266/jenkins.war
export JENKINS_HOME=~/.jenkins-64072
java -jar jenkins-plugin-manager-2.1.2.jar -f abdul-bas-plugins.txt -d ~/.jenkins-64072/plugins --war jenkins.war
java -jar jenkins.war

and then disable plugins till you find the issue

I had to remove warnings, analysis-core and zap-pipeline as they are no longer available

timja commented 3 years ago

basith:

Thanks timja. Issue was with "Environment Dashboard Plugin" Plugin. Managed to uninstall/disable and it worked.

timja commented 3 years ago

cryptomatt:

timja here you go.

in the plugin list its shown as Branch API Plugin (branch-api): 2.6.3

timja commented 3 years ago

timja:

Nice Abdul can you create an issue and add the tables-to-docs-regression label please

timja commented 3 years ago

timja:

Matthew can you do a new plugins export as in your one it had an old version and then take a screenshot of where your issue is not the plugin version

timja commented 3 years ago

cryptomatt:

timja  here you go. even after selecting pipeline script from SCM for a simple existing pipeline job it doesnt show any SCM attributes to choose from. Jenkins version is 2.266

 

not sure but i see this error in the build triggers section although i have not chosen anything

JS console errors as reported by others

 

For a brand new multibranch pipeline job, the screen is messed up with the GIT URL showing but the save button isnt working and similar JS errors as above.

plugins-18-11.txt

timja commented 3 years ago

JIRAUSER130300:

I'm facing the same issue since upgrading from version 2.263.
Here is the pastebin link to my full installed plugin > https://pastebin.com/yVtS6Fck
The paste data is delimited by "|", columns are LongName, Shortname,version, active, url
(The xml plugin list and perl command did not work for me, so I used json and jq instead)

Apart from the behavior.js, hudson js and select js errors reported above, these are the stuff i see from dev console.

 

At the job configuration screen for a new job, the layout are off and buttons are not working.

 

And I saw there were some alerts on old data format and this is what I see.

 

 

timja commented 3 years ago

JIRAUSER130308:

Also facing this issue, plugin list found here: https://pastebin.com/X7XmYT8v

 

Screenshot of JS errors added:

timja commented 3 years ago

JIRAUSER130313:

I tried to go through and disable anything mentioned in this thread. 

My specific issues:

When attempting to load the configuration for a build, the layout is screwed up

 

I do have the Save/Apply buttons, but clicking Save does nothing, and clicking apply does the following:

Nothing is in the box, so I didn't capture the whole thing.

I first noticed this issue on the Global Security page with the Active Directory plugin active. I figured it was just that plugin since the page was fine with it disabled. However, I'm seeing it now on my build configuration pages as well.  These are the javascript errors I see in the console

I've tried it in Edge (chromium) and IE (whatever the last version before edge was) and same behavior.

Here is the list of my plugins:

https://pastebin.com/p8zkew4p

 

timja commented 3 years ago

cryptomatt:

Hi timja is there an update to this issue? Any workaround that I can apply or is everyone rolling back to the last working Jenkins version?

timja commented 3 years ago

timja:

I haven’t had time to look at your one, you can identify which plugin it is by disabling till it works

timja commented 3 years ago

JIRAUSER130418:

Hi timja

Jenkins 2.267
All plugins update

Plugin list found here:1.txt

https://gyazo.com/cb0cd5972ebc4a480bd2f5abf5f128e2

My configure pages and save buttons stopped working

timja commented 3 years ago

cryptomatt:

hi timja I have disabled all uninstallable plugins and the problem still remains. 

timja commented 3 years ago

timja:

Hi everyone,

Just to let you know I'm prioritising issues now where people have managed to identify themselves the plugin which is causing the issue.
These show up on the dashboard: https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741

Once those are fixed I'll come back here.

Anyone else triaging issues would be much appreciated

The basic flow is:

1. check plugins list against open issues on https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741
2. then if no open issue matches:

curl https://issues.jenkins.io/secure/attachment/53350/53350_jenkins-basith-16112020.txt | sort > abdul-bas-plugins.txt
cat abdul-bas-plugins.txt | cut -d ':' -f 1 | sort > plugins.filtered.txt # remove versions as CLI complains when old versions are there
wget https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/2.1.2/jenkins-plugin-manager-2.1.2.jar
wget https://get.jenkins.io/war/2.266/jenkins.war
export JENKINS_HOME=~/.jenkins-64072
java -jar jenkins-plugin-manager-2.1.2.jar -f abdul-bas-plugins.txt -d ~/.jenkins-64072/plugins --war jenkins.war
java -jar jenkins.war

Normally create a new freestyle job and then reproduce the issue, (requires enough information with steps to reproduce, sometimes it is a different page or requires specific config)
Once reproduced disable plugins in groups of about 10 and record which ones you disabled
Restart Jenkins
If you can still reproduce keep disabling
Once you can't reproduce enable plugins one by one until you find which one it is
Then report an issue with the label 'tables-to-divs-regression'

timja commented 3 years ago

timja:

Artifactory plugin is fixed in the latest release

timja commented 3 years ago

fqueiruga:

For those affected by the bitbucket-branch-source-plugin, there's a PR pending release that should fix most issues (https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/399/). This, together with another PR https://github.com/jenkinsci/jenkins/pull/5081 that could be released in Jenkins 2.269 should fix some of these issues.

timja commented 3 years ago

JIRAUSER130300:

I managed to find out the "environment-dashboard" plugin is breaking UI in my case
Opened a case and the case can be found here > https://issues.jenkins.io/browse/JENKINS-64336

 

timja commented 3 years ago

dborin:

I'm running on Ubuntu 18.04, seeing this as well.  Several of the already diagnosed plugins are affecting my install.  Disabling them or uninstallng has had no affect.  We're using v2.261, and I've resigned myself to no longer upgrading plugins or version until this is resolved.  I'm not sure why this isn't more a priority, considering that so many plugins have been reported as a possible cause.  Jenkins isn't really useful without it's plugins, and not being to make changes to configurations seems to me to be a bit of an issue.  I also know that I simply don't have time to go through every plugin trying to find the one or two or ten that I need to disable or uninstall so I can upgrade.

timja commented 3 years ago

timja:

Could you provide the list please so it can be fixed?

timja commented 3 years ago

dborin:

Apologies, I deleted or uninstalled 4 plugins that were listed in various places and in the several bug tickets associated with this issue.  None of them were plugins I used (they were some of the many that come pre-configured with a default install from way back when, I've never paid attention to them).  I didn't keep track of them because I've never used them.

timja commented 3 years ago

amidar:

Hi timja,

following your request from dborin, I've attached here (jenkins plugins in use.txt) the list of plugins installed on our jenkins server. 

We also have the same problem (broken UI, unable to figure which plugin is causing the problem).

Let me know if there is anything else you need to help solve this issue, we are currently using jenkins 2.263.1 in order to work properly.

timja commented 3 years ago

timja:

amidar can you use the script from the top of the issue please? it can be used to build a reproducible environment and it's also a lot easier to read

timja commented 3 years ago

amidar:

timja, here is the list after running the script: jenkins plugins in use - correct format.txt

timja commented 3 years ago

timja:

amidar disabling ClearCase Plug-in is enough for free style jobs to work https://issues.jenkins.io/browse/JENKINS-64499

disabling Micro Focus Application Automation Tools is enough for system configuration https://issues.jenkins.io/browse/JENKINS-64500

timja commented 3 years ago

amidar:

timja - thanks for the heads up! sadly, those two plugins are still in use (yes, clear case is STILL in use!) in our system.

I noticed recently a member of the praqma team/company who wrote this plugin in the first place sending some update in the developer distribution list, any chance to get their attention on this matter?

I'm certain micro focus will solve this in the next release of their plugin, so i'm not worried about that end.

 

 

timja commented 3 years ago

timja:

I’ve tagged the person you mentioned in the other issue

timja commented 3 years ago

amidar:

timja, i'm crossing my fingers

timja commented 3 years ago

markewaite:

amidar have you considered offering to maintain the ClearCase plugin yourself? If you're a ClearCase user, then that likely means you have access to an environment where you could test changes that you make to the ClearCase plugin. Companies that depend on ClearCase are often deeply attached to it because of the large cost to switch to another SCM system. Since your company has already accepted that they won't spend the money to switch to another SCM system, you could ask them instead to fund a person to maintain the Jenkins ClearCase plugin for your use. Your company would benefit from a working ClearCase plugin and the Jenkins community would benefit from your company's work on the plugin.

Unless you have a support contract with Praqma Support, I would not expect them to do any maintenance on the ClearCase plugin. ClearCase is not a heavily used SCM system and it is unlikely that they have access to a ClearCase system any longer.

timja commented 3 years ago

timja:

ruslan_y2020 your issue appears to be the TFS plugin,

that is tracked here: JENKINS-64241

Note the TFS plugin is currently suspended from distribution see INFRA-2751

timja commented 3 years ago

timja:

chasepeeler your issue is the notifications plugin JENKINS-64254, fix is here https://github.com/jenkinsci/notification-plugin/pull/40

and a pre-release version is https://ci.jenkins.io/job/Plugins/job/notification-plugin/job/PR-40/11/artifact/target/notification.hpi

timja commented 3 years ago

timja:

jstr I am unable to reproduce your issue.

Either it has been fixed, I'm missing something, or it's one of the 10 plugins that you have that are either suspended or not distributed from the Jenkins update center.

plugins I couldn't install:

dynamicparameter
encryption-tool-runner
fileoperations-tool-runner
languagerelease-tool-runner
propsfileupdater-tool-runner
setversion-tool-runner
sign-files-plugin
translation-tool-runner
trex-runner
tron-runner
timja commented 3 years ago

amidar:

markewaite, regarding your answer on ClearCase - our company moved two years ago to GitLab. since we still have a LOT of legacy, there are still some projects maintained in ClearCase. as much as I would love having the time to maintain the ClearCase plugin, it has no future within our company (and might I add - the entire world).

no sane manager would allocate money/person/time for such a task, I think it would be much easier maintaining a Jenkins server for the legacy projects (on the latest 2.263 LTS line) and another server for everyone else....

sometimes we must admit that backward compatibility breaks - and I have to say I think this time has arrived for us... (unless ewel will prove me wrong, ofcourse...  )

timja commented 3 years ago

JIRAUSER130308:

timja Thank you for trying to reproduce the issue.

I checked again today after applying all outstanding updates. I don't see any change. What's still happening, or what the issue may have been reduced to, is a premature bottom end of the list of build steps. The remaining ones are then no longer framed with spacing on the left and right and a grey background. Those build steps that exceed the correctly rendered part of the build step list can then also no longer be dragged and dropped to a different position. Other build steps appear in an entire visual column next to the configure space.

The common denominator between those bugs seems to be the css class "repeated-chunk".

As for the list of plugins you couldn't install, they're all just in-house clones of the Windows Exe Runner plugin, serving as a wrapper/command-line argument sanitizer for smaller tools on the build server. They're not shared publicly since there really isn't any benefit other than parameter-hand-holding. I uploaded one of them to github for the purposes of transparency.

None of them do any more in terms of UI than provide a jelly and a properties file for the installation and the build step each.

timja commented 3 years ago

timja:

jstr can you please upload a full page screenshot or at least a screenshot where the page breaks?

The css class is a symptom of the issue but not really relevant in tracking down where the issue is.

in most cases it's a matter of checking the last plugin before the UI breaks

timja commented 3 years ago

JIRAUSER130916:

Hi,
We're having the same issue but in the configureClouds page. other configuration pages seems fine.
I we're using  at least two plugins that are listed here as causing issues (branch-api and env-inject), but since we have production assets relying on this server, I can't currently work on triaging the plugins to figure out which one is causing it or if upgrading the branch-api plugin will fix it.
I need to downgrade the version so we'll be able to work properly. But in case some one can/want to try and pinpoint the issue
Added screenshot configureClouds.png
 
Jenkins version is 2.271. Used plugins: jenkins_plugins.txt

timja commented 3 years ago

JIRAUSER130308:

timja Absolutely, they are attached as Project 1 and Project 2, I merely blackened (well, orange'd) some identifying strings

timja commented 3 years ago

timja:

matangoren you need at least version 1.54 of the EC2 plugin for it to work on >=2.264

timja commented 3 years ago

timja:

jstr reproduced, it required adding a build step to the configuration from the Parameterized Trigger plugin, created JENKINS-64502