[JENKINS-65398] Terminology update for master, whitelist, blacklist

timja commented 3 years ago

In July 2020 we adopted the "controller" term instead of "master", and deprecated the "whitelist/blacklist" terms. There are many places where the old terminology still needs to be replaced.

For example, deprecated term can be:

in UI files, like *.jelly, *.groovy, *.html
in logs that ends up in job console, or Jenkins console
in cli output
HTTP API
Documentation, README, code comments

Changing master in other context (like git or any scm master branch) is out of scope of this Epic.
We invite contributors to join us and participate in cleaning up Jenkins documentation, Web and CLI interfaces, and the codebase.

Deprecated term	To be replaced by
master	built-in when used for node/label controller (for everything else)
slave	agent (please use https://issues.jenkins.io/browse/JENKINS-42816 )
whitelist	allowlist (default but can be adapted to context)
blacklist	denylist or blocklist (default but can be adapted to context)

If you are working on slave/agent replacement please use https://issues.jenkins.io/browse/JENKINS-42816

Originally reported by ajard, imported from: Terminology update for master, whitelist, blacklist

status: Open
priority: Minor
resolution: Unresolved
imported: 2022/01/10

timja commented 3 years ago

ajard:

https://github.com/jenkinsci/docker-build-publish-plugin/pull/60
https://github.com/jenkinsci/promoted-builds-plugin/pull/152

timja commented 3 years ago

oleg_nenashev:

Should we keep agent cleanup in JENKINS-42816 ?

timja commented 3 years ago

ajard:

oleg_nenashev I have no strong opinion, I don't think that there are PRs with agent renaming only (it's often mainly controller and some agent in the way), but we can link both Epic maybe. But I can update the description to redirect to the other Epic for agent (I like to see the mapping all old word -> new word in one place).

timja commented 3 years ago

ajard:

I have updated the description with a link to Agent renaming Epic, I hope it fits all needs

timja commented 3 years ago

kerogers:

Another PR for this epic https://github.com/jenkinsci/workflow-api-plugin/pull/147

timja commented 3 years ago

amuniz:

One more https://github.com/jenkinsci/pubsub-light-plugin/pull/35

timja commented 3 years ago

vlatombe:

timja commented 3 years ago

ikedam:

Rewriting changelogs may feel strange for maintainers.
(I actually once considered to finish the review with "Request changes" in copyartifact-plugin)

It would be helpful to clarify that it's expected to update even changelogs as the Jenkins community policy
though it's finally up to maintainers whether they update changelogs.
(I believe it's the community policy according to https://github.com/jenkins-infra/jenkins.io/pull/4302 .)

timja commented 3 years ago

ajard:

I don't rewrite changelogs, I feel that we shouldn't change the past but maybe I am wrong. I don't have strong opinion, not sure that there is an community agreement.

timja commented 3 years ago

ikedam:

I want a guideline for cases where plugins contain translations that maintainer cannot maintain.

Create tickets for those translations.
Leave TODO file or TODO comments in files.
Remove translations supposed to contain terminologies that should be update.

reference: https://github.com/jenkinsci/copyartifact-plugin/pull/138/commits/7bbbafa5ad81e70d1a404e2eb88977c31602ed3d#r639029081

timja / jenkins-gh-issues-poc-06-18

[JENKINS-65398] Terminology update for master, whitelist, blacklist #1482