timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-65907] disableConcurrentBuilds not enforced after upgrade to 2.289.1 #1558

Open timja opened 3 years ago

timja commented 3 years ago

Our team uses a branch build with a scripted pipeline backed by groovy scripts. The branch builds fail when run concurrently. We set them up like this at the top of the groovy script:

node {
properties([
disableConcurrentBuilds(),
buildDiscarder(logRotator(artifactNumToKeepStr: '10', numToKeepStr: '10'))
])
...

After upgrading to 2.289.1 the disableConcurrentBuilds is not respected and the builds are run concurrently... and fail. We do need multiple executors for other jobs so setting # executors to 1 is not a workaround for my team.

Possibly related to: JENKINS-65673


Originally reported by mkelandis, imported from: disableConcurrentBuilds not enforced after upgrade to 2.289.1
  • status: Open
  • priority: Blocker
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 3 years ago

jglick:

FWIW

mvn -f workflow-multibranch-plugin test -Dtest=JobPropertyStepTest\#concurrentBuildProperty -Djenkins.version=2.289.1

still passes.

timja commented 2 years ago

torstenboelting:

Perhaps same Problem here.  In some of our Jobs (and in some Folders all Jobs) the setting of LogRotator, disableConcurrentBuilds and even TimerTrigger doesn't work after upgrading to 2.289.1.
If we set new values in one of these parameters (via UI-Config or via Pipeline-Script) they are overwritten with an old value after the next build starts.
Config-History says "Changed by SYSTEM"

timja commented 2 years ago

torstenboelting:

Update: TimeTrigger does work, Failure of User.
LogRotator and disableConcurrentBuilds don't work on some Jobs.