search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-67844] New icon theming not applied to non-core icons #1843

Open timja opened 2 years ago

timja commented 2 years ago

Since Jenkins 2.335 core SVG icons in the side panel are colored in blue (using a corresponding CSS class and the SVG attribute stroke='currectColor'). This coloring seems not to be applied to SVG icons that are not part of Jenkins core. It would be helpful if those icons would be colored in the same way.

In this example, the Coverage Report is painted in black, but the Delete Pipeline is painted in blue.

Originally reported by drulli, imported from: New icon theming not applied to non-core icons
  • assignee: janfaracik
  • status: Open
  • priority: Minor
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 2 years ago

drulli:

I'm not sure if that can be done in the plugin SVG or if the CSS that wraps the SVG needs to be adapted in core.

timja commented 2 years ago

JIRAUSER136250:

Hey, icon theming isn't possible for SVGs that are loaded via the `` tag sadly. Just thinking off the top of my head I don't think it's possible for plugin developers to use icon theming for things like sidebar icons etc (yet) - this will be resolved when custom symbols are merged in.

timja commented 2 years ago

drulli:

I see. Why do we load SVGs with the tag? Shouldn't Jenkins Core care about the correct handling of the file type?