search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-68390] Build number cut off on safari (regression in 2.344) #1983

Open timja opened 2 years ago

timja commented 2 years ago

Safari:

 

Chrome:

 

cc janfaracik 

Originally reported by timja, imported from: Build number cut off on safari (regression in 2.344)
  • status: Open
  • priority: Minor
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 2 years ago

timja:

Likely related to https://issues.jenkins.io/browse/JENKINS-68160

timja commented 2 years ago

alecharp:

timja I don't have access to a safari browser, but could you please try to find the cause of this by running a git bisect to understand the commit / pull request which introduced this issue?

timja commented 2 years ago

danielbeck:

This started in 2.344. 2.343 is unaffected.

timja commented 2 years ago

danielbeck:

Wild guess (bisecting right now): JENKINS-68129

timja commented 2 years ago

danielbeck:

The (2 digit) build number is wrapped when there is no build badge, but the presence of a build badge (including "Keep forever") will instead truncate it.

timja commented 2 years ago

danielbeck:

$ git bisect bad
900374e12421204f9ad76ac84397e96b9399cf00 is the first bad commit
commit 900374e12421204f9ad76ac84397e96b9399cf00
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Apr 15 21:59:48 2022 +0100    [JENKINS-68129] Fix dropdown chevrons not separating links and overflowing (#6481) war/src/main/less/modules/breadcrumbs.less | 175 ++++++++++++++++-------------
 war/src/main/less/modules/page-header.less |  13 ++-
 war/src/main/less/modules/table.less       |   6 +
 3 files changed, 113 insertions(+), 81 deletions(-)

$ git bisect log
git bisect start
# bad: [f0d27d14b45acf9a1baad8301abbd1c6b69ef493] Bump `extras-executable-war` from 2.3 to 2.4 (#6487)
git bisect bad f0d27d14b45acf9a1baad8301abbd1c6b69ef493
# good: [4a38d651fbdba6fc67c02584ebd95a4c43ead78a] [JENKINS-51913] Prevent `archiveArtifacts` from displaying a stack trace when no artifacts are found (#6475)
git bisect good 4a38d651fbdba6fc67c02584ebd95a4c43ead78a
# bad: [964c898dfc0f7655be94d40f82c1aab908a439bf] Merge pull request #6486 from janfaracik/fix-disable-plugin
git bisect bad 964c898dfc0f7655be94d40f82c1aab908a439bf
# bad: [928da56fc9993923db937390372b77e26cef3b71] Add dropdown to user cause trigger (#6276)
git bisect bad 928da56fc9993923db937390372b77e26cef3b71
# bad: [5caaf2874ad9c830695a41c59f229e6d98e4a8c3] Miscellaneous code cleanup (#6046)
git bisect bad 5caaf2874ad9c830695a41c59f229e6d98e4a8c3
# bad: [900374e12421204f9ad76ac84397e96b9399cf00] [JENKINS-68129] Fix dropdown chevrons not separating links and overflowing (#6481)
git bisect bad 900374e12421204f9ad76ac84397e96b9399cf00
# first bad commit: [900374e12421204f9ad76ac84397e96b9399cf00] [JENKINS-68129] Fix dropdown chevrons not separating links and overflowing (#6481)