search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-35450] Rename environment variable: JENKINS_SLAVE_AGENT_PORT to JENKINS_AGENT_PORT #3233

Open timja opened 8 years ago

timja commented 8 years ago

Found while using Jenkins 2.6 docker container, so it needs to be fixed both there and in core.

Originally reported by bitwiseman, imported from: Rename environment variable: JENKINS_SLAVE_AGENT_PORT to JENKINS_AGENT_PORT
  • status: Open
  • priority: Minor
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 8 years ago

oleg_nenashev:

This change will be incompatible. -1, needs a better design

timja commented 8 years ago

bitwiseman:

oleg_nenashev How about providing both vars for a while with at task for removing the "slave" one in six months? Is eternal backward compat required?

timja commented 8 years ago

bitwiseman:

The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

I understand that env vars are effectively part of the API and so changing them is problematic and could be considered out of scope.   But they are also part of the end-user experience (the UI) for every Jenkins user.

timja commented 2 years ago

[Originally related to: JENKINS-31095]

timja commented 2 years ago

[Originally related to: JENKINS-35449]

timja commented 2 years ago

[Epic: JENKINS-42816]