search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-37546] When dynamic plugin load fails, PermissionGroups are not being cleaned up #3454

Open timja opened 8 years ago

timja commented 8 years ago

Noticed it during JENKINS-37545.

Reproduction steps:
1) Manually deploy a plugin with detached dependencies and permission groups (e.g. Ownership 0.5)
2) The loading should fail...
3) Install missing dependencies
4) Deploy the plugin again
5) Change the log

Expected behavior:
The plugin installation succeeds

Actual behavior:
Plugin installation fails due to the missing permission group

Workaround:
Restart the instance

Originally reported by oleg_nenashev, imported from: When dynamic plugin load fails, PermissionGroups are not being cleaned up
  • status: Open
  • priority: Major
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 8 years ago

jglick:

Probably should be fixed implicitly by a rewrite of permission registration, as mentioned in JENKINS-17200.

timja commented 5 years ago

jvz:

In my current proposal around permissions, this error wouldn't happen as permissions are loaded lazily. Before that, I also had a ConcurrentMap for registering permissions, so even that was using putIfAbsent to avoid duplicating permissions in the UI.

timja commented 2 years ago

[Originally related to: JENKINS-17200]