[JENKINS-41511] Cannot change any property in configureSecurity when slave agent port is enforced

[timja]

JENKINS-38187 introduced a flag to force jnlp port on startup. However, it broke form submission of configureSecurity because in that case the tcp port is not present in the form anymore.

javax.servlet.ServletException: net.sf.json.JSONException: null object
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:796)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.MetaClass$10.dispatch(MetaClass.java:362)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
    at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
    at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
    at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
    at com.cloudbees.jenkins.ha.HAHealthCheckFilter.doFilter(HAHealthCheckFilter.java:35)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135)
    at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at org.jenkinsci.plugins.suppress_stack_trace.SuppressionFilter.doFilter(SuppressionFilter.java:34)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at com.cloudbees.jenkins.support.slowrequest.SlowRequestFilter.doFilter(SlowRequestFilter.java:37)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at com.cloudbees.opscenter.security.ClusterSessionFilter._doFilter(ClusterSessionFilter.java:69)
    at com.cloudbees.opscenter.security.ClusterSessionFilter.doFilter(ClusterSessionFilter.java:44)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at jenkins.metrics.impl.MetricsFilter.doFilter(MetricsFilter.java:125)
    at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
    at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:126)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:80)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
    at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
    at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:553)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
    at org.eclipse.jetty.server.Server.handle(Server.java:499)
    at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
    at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
    at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
    at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
Caused by: net.sf.json.JSONException: null object
    at net.sf.json.JSONObject.verifyIsNull(JSONObject.java:2688)
    at net.sf.json.JSONObject.getString(JSONObject.java:2035)
    at jenkins.util.ServerTcpPort.(ServerTcpPort.java:23)
    at hudson.security.GlobalSecurityConfiguration.configure(GlobalSecurityConfiguration.java:118)
    at hudson.security.GlobalSecurityConfiguration.doConfigure(GlobalSecurityConfiguration.java:99)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:335)
    at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:175)
    at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:108)
    at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:124)
    at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
    at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
    ... 55 more

---

Originally reported by vlatombe, imported from: Cannot change any property in configureSecurity when slave agent port is enforced

• assignee: vlatombe
• status: Resolved
• priority: Minor
• resolution: Fixed
• resolved: 2017-01-30T16:37:23+00:00
• imported: 2022/01/10

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
test/src/test/groovy/jenkins/bugs/Jenkins41511Test.java
http://jenkins-ci.org/commit/jenkins/a26d71153d7609094e449d371d3ab0f8415b887f
Log:
JENKINS-41511 Add a test showing the problem

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/security/GlobalSecurityConfiguration.java
http://jenkins-ci.org/commit/jenkins/5b9c10d6b049c12dafaefea75178c5ed4bb7b9bc
Log:
JENKINS-41511 Don't try to set slaveAgentPort when it is enforced

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/security/GlobalSecurityConfiguration.java
http://jenkins-ci.org/commit/jenkins/d8859876cbec775949c8f45d55735a1f5fc81edb
Log:
JENKINS-41511 Remove obsolete comment

[timja]

scm_issue_link:

Code changed in jenkins
User: Daniel Beck
Path:
core/src/main/java/hudson/security/GlobalSecurityConfiguration.java
test/src/test/groovy/jenkins/bugs/Jenkins41511Test.java
http://jenkins-ci.org/commit/jenkins/5f5e86def76c21373b2a8f67b16c5599ca92ad90
Log:
Merge pull request #2726 from Vlatombe/JENKINS-41511

JENKINS-41511 Don't try to set slaveAgentPort when it is enforced

Compare: https://github.com/jenkinsci/jenkins/compare/f0c941617771...5f5e86def76c

[timja]

danielbeck:

https://wiki.jenkins-ci.org/display/JENKINS/GitHub+commit+messages
https://wiki.jenkins-ci.org/display/JENKINS/Instructions+for+Committers

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
test/src/test/groovy/jenkins/bugs/Jenkins41511Test.java
http://jenkins-ci.org/commit/jenkins/e46099aead4081dcbb1e14a797f1680bd35bf68d
Log:
JENKINS-41511 Add a test showing the problem

(cherry picked from commit a26d71153d7609094e449d371d3ab0f8415b887f)

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/security/GlobalSecurityConfiguration.java
http://jenkins-ci.org/commit/jenkins/19d2b2c54dcada4410ab65939c1fec17636e03fd
Log:
JENKINS-41511 Don't try to set slaveAgentPort when it is enforced

(cherry picked from commit 5b9c10d6b049c12dafaefea75178c5ed4bb7b9bc)

[timja]

scm_issue_link:

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/security/GlobalSecurityConfiguration.java
http://jenkins-ci.org/commit/jenkins/9f8380941cfea338f06f03c014174f811f5fa797
Log:
JENKINS-41511 Remove obsolete comment

(cherry picked from commit d8859876cbec775949c8f45d55735a1f5fc81edb)