search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-41825] Page loads breaks when View.getItems fails #3854

Closed timja closed 7 years ago

timja commented 7 years ago

It is not uncommon for an error to be thrown from View.getItems. Currently Jenkins behaves poorly in this case: it displays an "oops" page with a cryptic stack trace

java.lang.NullPointerException: Cannot invoke method isEmpty() on null object
at org.codehaus.groovy.runtime.NullObject.invokeMethod(NullObject.java:77)
at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:45)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
at org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:32)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112)
at hudson.model.View.main.run(main.groovy:6)

that has no relation to the real error.

Originally reported by jglick, imported from: Page loads breaks when View.getItems fails
  • assignee: jglick
  • status: Resolved
  • priority: Minor
  • resolution: Fixed
  • resolved: 2017-02-10T15:47:17+00:00
  • imported: 2022/01/10
timja commented 7 years ago

jglick:

Linking to some examples of this, but from this search you can see there at least a dozen cases.

timja commented 7 years ago

scm_issue_link:

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/resources/hudson/model/View/main.groovy
core/src/main/resources/hudson/model/View/main.properties
test/src/test/java/hudson/model/ViewTest.java
http://jenkins-ci.org/commit/jenkins/fcf4ca7697b4a5293c95b221669f202621b178f7
Log:
[FIXED JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails.

timja commented 7 years ago

scm_issue_link:

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/resources/hudson/model/View/main.groovy
core/src/main/resources/hudson/model/View/main.properties
test/src/test/java/hudson/model/ViewTest.java
http://jenkins-ci.org/commit/jenkins/da2f57c7221742bda5a97bf8c026d6b9dd42fcd5
Log:
[FIXED JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails.
(cherry picked from commit fcf4ca7697b4a5293c95b221669f202621b178f7)