timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-54957] Investigate Impact of java.sql modularization on classic Jenkins modes #4136

Closed timja closed 5 years ago

timja commented 6 years ago

I discovered that Jenkinsfile Runner does not work reliably with Java 11 when there is a plugin using "java.sql" internally (JENKINS-54426). It impacts Pipeline Utility Steps (JENKINS-54355), and it will likely also impact Pipeline: Maven Plugin and other plugins: https://github.com/search?p=2&q=org%3Ajenkinsci+%22java.sql%22&type=Code . For JFR the most critical thing is Pipeline plugins, of course.  CC rsandell cleclerc

We need to investigate whether the failing behavior is also possible on classic Jenkins instances

 


Originally reported by oleg_nenashev, imported from: Investigate Impact of java.sql modularization on classic Jenkins modes
  • status: Resolved
  • priority: Minor
  • resolution: Fixed
  • resolved: 2019-02-06T15:35:38+00:00
  • imported: 2022/01/10
timja commented 5 years ago

batmat:

> We need to investigate whether the failing behavior is also possible on classic Jenkins instances

This has been analyzed by alecharp in JENKINS-54355 and it is not reproducible in a standard environment. Pipeline-utility-steps works perfectly fine on JDK11 without using any additional --add-modules ...,java.sql switch.

We've seen this issue surface at least in PCT, in JFR, so my current suspicion is that this issue is triggered by a special classloading used there (JTH?).

timja commented 5 years ago

vilacides:

Since fcojfernandez removed junit he is the best suited to try to reproduce this issue cause it's likely that it's not happening anymore

timja commented 5 years ago

oleg_nenashev:

I believe it was fixed by egutierrez in https://github.com/jenkinsci/jenkinsfile-runner/commits/master

 

If egutierrez and fcojfernandez agree, I propose to close it

timja commented 5 years ago

egutierrez:

Sounds good to me. It should be solved as proved by https://github.com/jenkinsci/jenkinsfile-runner/tree/master/demo/cwp-jdk11

timja commented 5 years ago

fcojfernandez:

Go ahead Oleg! I'm fine with closing it

timja commented 2 years ago

[Epic: JENKINS-51805]