search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-27176] plugin management must log details about upgrades to support forensic analysis #5925

Open timja opened 9 years ago

timja commented 9 years ago

The current loging is insufficient level of detial and criticality

upgrade:
Feb 28, 2015 10:49:57 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of GitHub Plugin on behalf of jpyeron
Feb 28, 2015 10:49:57 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading GitHub Plugin
Feb 28, 2015 10:49:58 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Git Client Plugin on behalf of jpyeron
Feb 28, 2015 10:49:59 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Git Client Plugin
Feb 28, 2015 10:50:00 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Git Plugin on behalf of jpyeron
Feb 28, 2015 10:50:00 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Git Plugin
Feb 28, 2015 10:50:01 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Script Security Plugin on behalf of jpyeron
Feb 28, 2015 10:50:02 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Script Security Plugin
Feb 28, 2015 10:50:02 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of JUnit Plugin on behalf of jpyeron
Feb 28, 2015 10:50:02 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading JUnit Plugin
Feb 28, 2015 10:50:02 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Matrix Project Plugin on behalf of jpyeron
Feb 28, 2015 10:50:03 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Matrix Project Plugin
Feb 28, 2015 10:50:03 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Mailer on behalf of jpyeron
Feb 28, 2015 10:50:03 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Mailer
Feb 28, 2015 10:50:03 AM hudson.model.UpdateCenter$DownloadJob run
INFO: Starting the installation of Git Client Plugin on behalf of jpyeron
Feb 28, 2015 10:50:04 AM hudson.model.UpdateCenter$UpdateCenterConfiguration download
INFO: Downloading Git Client Plugin
Feb 28, 2015 11:20:02 AM hudson.model.UpdateCenter doSafeRestart
INFO: Scheduling Jenkins reboot

downgrade:
Feb 28, 2015 12:28:10 PM hudson.model.UpdateCenter$PluginDowngradeJob run
INFO: Starting the downgrade of Matrix Project Plugin on behalf of anonymous
Feb 28, 2015 12:28:10 PM hudson.model.UpdateCenter$PluginDowngradeJob run
INFO: Downgrade successful: Matrix Project Plugin

The upgrade and downgrade actions need to log the old and new version numbers for each plugin change at the warning level, to ensure it being recorded to the log.

See thread https://groups.google.com/d/msgid/jenkinsci-users/CAO49JtFuG9t_F4zL%3D7ncg53XdZG9dZD-GdWQ1dtTN53DrKjm8g%40mail.gmail.com

Originally reported by jpyeron, imported from: plugin management must log details about upgrades to support forensic analysis
  • assignee: jpyeron
  • status: Open
  • priority: Major
  • resolution: Unresolved
  • imported: 2022/01/10
timja commented 9 years ago

jpyeron:

The UI may also benefit from this change.

On restart Jenkins crashed and the admin was left with:

Installing Plugins/Upgrades
Preparation

Checking internet connectivity
Checking update center connectivity
Success

GitHub Plugin Downloaded Successfully. Will be activated during the next boot
Git Client Plugin Downloaded Successfully. Will be activated during the next boot
Git Plugin Downloaded Successfully. Will be activated during the next boot
Script Security Plugin Downloaded Successfully. Will be activated during the next boot
JUnit Plugin Downloaded Successfully. Will be activated during the next boot
Matrix Project Plugin Downloaded Successfully. Will be activated during the next boot
Mailer Downloaded Successfully. Will be activated during the next boot
Git Client Plugin Downloaded Successfully. Will be activated during the next boot
Restarting Jenkins Running

on the screen. If there were version numbers, the SA would have a place to start with debugging.

timja commented 9 years ago

danielbeck:

(Edited: In the rare case of the UI breaking completely, this request does have merit.)

timja commented 9 years ago

danielbeck:

Is this self-assigned because you plan to work on it?

timja commented 9 years ago

danielbeck:

Classifying as Major and Improvement.

HPI/JPI files are just zip archives (like JARs), and they contain fairly easy to find version metadata. So there's a somewhat easy workaround present for this situation.

timja commented 9 years ago

jpyeron:

yes I self assigned because I would like to take a crack at it. I think this should be fixable by someone who has never hacked Jenkins code before.