[JENKINS-32232] RSS entry IDs are not unique for nested items (folders, multibranch projects, etc)

timja commented 8 years ago

Original reporter https://github.com/mrcarlosrendon

Consider the following two entries found in the rssAll feed


</span>nctnhbaseworker/trunk #19 (stable)<span class="code-tag">
"text/html" href="http://irv-dev-pibld1:8080/job/nctnhbaseworker/branch/trunk/19/" rel="alternate"/>
tag:hudson.dev.java.net,2015:trunk:19
2015-12-22T00:02:26Z
2015-12-22T00:02:26Z


</span>psclient/trunk #19 (1 test is still failing)<span class="code-tag">
"text/html" href="http://irv-dev-pibld1:8080/job/psclient/branch/trunk/19/" rel="alternate"/>
tag:hudson.dev.java.net,2015:trunk:19
2015-12-22T00:04:24Z
2015-12-22T00:04:24Z

They are for two different projects, but the tag for them is identical which breaks RSS feed readers that are expecting each entry to have a unique id as is required by the ATOM specification (http://tools.ietf.org/html/rfc4287#section-4.2.6) that Jenkins uses.

I think adding the project name in addition to the branch name in the id field would solve the issue.

Originally reported by mjdetullio, imported from: RSS entry IDs are not unique for nested items (folders, multibranch projects, etc)

status: Closed
priority: Minor
resolution: Fixed
resolved: 2016-07-19T19:02:33+00:00
imported: 2022/01/10

timja commented 8 years ago

danielbeck:

Would something like tag:hudson.dev.java.net,2015:foo/bar/trunk:19 be a valid ID? That would be trivial to do, but RFC 3987 is a bit more than I'd like to deal with right now.

timja commented 8 years ago

danielbeck:

Reference: https://github.com/jenkinsci/jenkins/blob/9ab3f1d6aa15a242d226b45664bbb1a8dd0c9818/core/src/main/java/hudson/model/Run.java#L2397 probably just needs a getFullName() instead.

timja commented 8 years ago

danielbeck:

Probably also an issue in e.g. Maven projects.

timja commented 8 years ago

danielbeck:

mjdetullio Ping!

timja commented 8 years ago

mjdetullio:

Looks like this was duped by ~~JENKINS-34767~~ and then fixed https://github.com/jenkinsci/jenkins/commit/d8076e9654a4be6cd0792ea954363b209c44313b