timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-6862] Wrong link to Ant Manual (Filesets) in several places #797

Closed timja closed 14 years ago

timja commented 14 years ago

In several places throughout the Hudson UI and help files, a link to the Apache Ant manual regarding Filesets is not working anymore.

The link used to be "http://ant.apache.org/manual/CoreTypes/fileset.html", but the correct link is now "http://ant.apache.org/manual/Types/fileset.html".

Searching through the Hudson source code for the string "CoreTypes" resulted in 78 occurrences. The (outdated) link is hardcoded in *.properties and *.html files in multiple plugins.

This could be a simple find and replace task. An even better solution would be, to avoid hardcoding this link into the *.properties files. I'm not sure though, if this is possible with the Jelly markup.

I could fix it myself, I just don't have commiter rights yet.

First Hudson bug report, so please be kind.


Originally reported by fredg02, imported from: Wrong link to Ant Manual (Filesets) in several places
  • assignee: mindless
  • status: Closed
  • priority: Minor
  • resolution: Fixed
  • resolved: 2010-06-27T14:20:58+00:00
  • imported: 2022/01/10
timja commented 14 years ago

scm_issue_link:

Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config.jelly
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_de.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_es.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_fr.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_ja.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_nl.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_pt_BR.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_ru.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/Fingerprinter/config_tr.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config.jelly
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_de.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_es.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_fr.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_ja.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_nl.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_pt_BR.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_ru.properties
trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/JUnitResultArchiver/config_tr.properties
trunk/hudson/main/war/resources/help/tasks/junit/report.html
trunk/hudson/main/war/resources/help/tasks/junit/report_de.html
trunk/hudson/main/war/resources/help/tasks/junit/report_fr.html
trunk/hudson/main/war/resources/help/tasks/junit/report_ja.html
trunk/hudson/main/war/resources/help/tasks/junit/report_nl.html
trunk/hudson/main/war/resources/help/tasks/junit/report_pt_BR.html
trunk/hudson/main/war/resources/help/tasks/junit/report_ru.html
trunk/hudson/main/war/resources/help/tasks/junit/report_tr.html
trunk/hudson/plugins/backup/src/main/webapp/help/help-jobExcludes.html
trunk/hudson/plugins/backup/src/main/webapp/help/help-jobIncludes.html
trunk/hudson/plugins/checkstyle/src/main/resources/hudson/plugins/checkstyle/CheckStylePublisher/config.jelly
trunk/hudson/plugins/checkstyle/src/main/resources/hudson/plugins/checkstyle/CheckStylePublisher/config.properties
trunk/hudson/plugins/checkstyle/src/main/resources/hudson/plugins/checkstyle/CheckStylePublisher/config_de.properties
trunk/hudson/plugins/checkstyle/src/main/resources/hudson/plugins/checkstyle/CheckStylePublisher/config_ja.properties
trunk/hudson/plugins/codescanner/src/main/resources/hudson/plugins/codescanner/CodescannerPublisher/config.properties
trunk/hudson/plugins/codescanner/src/main/resources/hudson/plugins/codescanner/CodescannerPublisher/config_de.properties
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToMasterNotifier/help-excludes.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToMasterNotifier/help-excludes_fr.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToMasterNotifier/help-includes.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToMasterNotifier/help-includes_fr.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToSlaveBuildWrapper/help-excludes.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToSlaveBuildWrapper/help-excludes_fr.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToSlaveBuildWrapper/help-includes.html
trunk/hudson/plugins/copy-to-slave/src/main/resources/com/michelin/cio/hudson/plugins/copytoslave/CopyToSlaveBuildWrapper/help-includes_fr.html
trunk/hudson/plugins/copyarchiver/src/main/resources/com/thalesgroup/hudson/plugins/copyarchiver/CopyArchiverPublisher/help-excludes.html
trunk/hudson/plugins/copyarchiver/src/main/resources/com/thalesgroup/hudson/plugins/copyarchiver/CopyArchiverPublisher/help-pattern.html
trunk/hudson/plugins/copyartifact/src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter.html
trunk/hudson/plugins/copyartifact/src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_ja.html
trunk/hudson/plugins/cppcheck/src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckPublisher/config.jelly
trunk/hudson/plugins/cppcheck/src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/CppcheckPublisher/config.properties
trunk/hudson/plugins/cpptest/src/main/resources/hudson/plugins/cpptest/CpptestPublisher/config.jelly
trunk/hudson/plugins/cpptest/src/main/resources/hudson/plugins/cpptest/CpptestPublisher/config.properties
trunk/hudson/plugins/dry/src/main/resources/hudson/plugins/dry/DryPublisher/config.jelly
trunk/hudson/plugins/dry/src/main/resources/hudson/plugins/dry/DryPublisher/config.properties
trunk/hudson/plugins/dry/src/main/resources/hudson/plugins/dry/DryPublisher/config_de.properties
trunk/hudson/plugins/dry/src/main/resources/hudson/plugins/dry/DryPublisher/config_ja.properties
trunk/hudson/plugins/japex/src/main/resources/hudson/plugins/japex/JapexPublisher/config.jelly
trunk/hudson/plugins/javatest-report/src/main/resources/hudson/plugins/javatest_report/JavaTestReportPublisher/config.jelly
trunk/hudson/plugins/jwsdp-sqe/src/main/resources/hudson/plugins/jwsdp_sqe/SQETestResultPublisher/config.jelly
trunk/hudson/plugins/klaros-testmanagement/src/main/resources/hudson/plugins/klaros/KlarosTestResultPublisher/config.jelly
trunk/hudson/plugins/klaros-testmanagement/src/main/resources/hudson/plugins/klaros/KlarosTestResultPublisher/config.properties
trunk/hudson/plugins/klaros-testmanagement/src/main/resources/hudson/plugins/klaros/KlarosTestResultPublisher/config_de.properties
trunk/hudson/plugins/klaros-testmanagement/src/main/webapp/help-testReport.html
trunk/hudson/plugins/mibsr/src/main/resources/hudson/plugins/mibsr/MIBSRPublisher/config.jelly
trunk/hudson/plugins/mibsr/src/main/resources/hudson/plugins/mibsr/MIBSRPublisher/config.properties
trunk/hudson/plugins/nunit/src/main/resources/hudson/plugins/nunit/NUnitPublisher/config.jelly
trunk/hudson/plugins/plot/src/main/webapp/help-properties.html
trunk/hudson/plugins/pmd/src/main/resources/hudson/plugins/pmd/PmdPublisher/config.jelly
trunk/hudson/plugins/pmd/src/main/resources/hudson/plugins/pmd/PmdPublisher/config.properties
trunk/hudson/plugins/pmd/src/main/resources/hudson/plugins/pmd/PmdPublisher/config_de.properties
trunk/hudson/plugins/pmd/src/main/resources/hudson/plugins/pmd/PmdPublisher/config_ja.properties
trunk/hudson/plugins/scp/src/main/webapp/help-source.html
trunk/hudson/plugins/seleniumhq/src/main/resources/hudson/plugins/seleniumhq/SeleniumhqPublisher/config.jelly
trunk/hudson/plugins/seleniumhq/src/main/resources/hudson/plugins/seleniumhq/SeleniumhqPublisher/config.properties
trunk/hudson/plugins/seleniumhq/src/main/resources/hudson/plugins/seleniumhq/SeleniumhqPublisher/config_fr.properties
trunk/hudson/plugins/skype/src/main/resources/hudson/plugins/skype/SkypeTestErrorPublisher/config.jelly
trunk/hudson/plugins/sloccount/src/main/resources/hudson/plugins/sloccount/SloccountPublisher/config.jelly
trunk/hudson/plugins/sloccount/src/main/resources/hudson/plugins/sloccount/SloccountPublisher/config.properties
trunk/hudson/plugins/sloccount/src/main/resources/hudson/plugins/sloccount/SloccountPublisher/config_de.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksPublisher/config.jelly
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksPublisher/config.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksPublisher/config_de.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksPublisher/config_ja.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksReporter/config.jelly
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksReporter/config.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksReporter/config_de.properties
trunk/hudson/plugins/tasks/src/main/resources/hudson/plugins/tasks/TasksReporter/config_ja.properties
trunk/hudson/plugins/text-finder/src/main/resources/hudson/plugins/textfinder/TextFinderPublisher/config.jelly
trunk/hudson/plugins/utplsql/src/main/resources/hudson/plugins/utplsql/UtplsqlRecorder/config.jelly
trunk/hudson/plugins/utplsql/src/main/resources/hudson/plugins/utplsql/UtplsqlRecorder/config.properties
trunk/hudson/plugins/utplsql/src/main/resources/hudson/plugins/utplsql/UtplsqlRecorder/config_de.properties
trunk/hudson/plugins/warnings/src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly
trunk/hudson/plugins/warnings/src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.properties
trunk/hudson/plugins/warnings/src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_de.properties
trunk/hudson/plugins/warnings/src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_ja.properties
trunk/hudson/plugins/xunit/src/main/webapp/help.html
trunk/hudson/plugins/xunit/src/main/webapp/table-help.html
http://jenkins-ci.org/commit/32324
Log:
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.

timja commented 14 years ago

drulli:

Integrated in Hudson Plug-ins (Compile) #20
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.
[FIXED JENKINS-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.

timja commented 14 years ago

fredg02:

Thanks for the quick fix.
When is this fix going to be released?

timja commented 14 years ago

mindless:

core changes already released.. plugins have no particular schedule, so whenever those plugin maintainers do their next releases..

timja commented 14 years ago

harrygg:

Sorry for the late comment on this already closed bug.
I found it in parallel and wanted to propose another URL, but came to late for this change.

The now used "http://ant.apache.org/manual/Types/fileset.html" is a documentation of FileSet only with some useful examples, but not fully explaining the path patterns.

The exact documentation would be this one:
http://ant.apache.org/manual/dirtasks.html#patterns

Regrettably it is not easy to navigate from FileSet to Patterns.

So I would propose to reopen this bug and use this better URL. Or should I file a new one?
Sorry again that I came so late...

timja commented 14 years ago

mindless:

Hm, as the links generally say "@includes of FileSet" it would seem odd to jump to something other than FileSet where it lists the includes attribute. From FileSet I clicked "PatternSet" in the first sentence of that page, and then "Pattern", which is the first word on that page, to reach the URL you mentioned. Sure, would be nice is "patterns" in the "includes" row of the table linked directly there (maybe file a request with apache ant ). I'm inclined to leave this as-is, but you can file a new issue if you like and see if it gets any votes.. thanks for the feedback.

timja commented 14 years ago

fredg02:

@mindless: sweet. I didn't see the bugfix being mentioned in the changelog, that's why I asked. Thanks again.

timja commented 14 years ago

harrygg:

I agree that this could also be solved on ant side. The navigation there sometimes is really weird (espacially compared to the intuitive hudson UI). As you said, it's just two clicks away, but only if you know where - a newbie won't find it easily...

Ok then, let's leave it like it is...