timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-105] "Behavior" framework makes Hudson config page help buttons inaccessible #8174

Closed timja closed 18 years ago

timja commented 18 years ago

You cannot access the help icon buttons on /job/*/configure pages using either
the TAB key or numbers when using the Firefox Mouseless Browsing (MLB)
extension. A plain HTML has no KB accessibility as the browser does not
consider it a real button; it is only made to act like one due to

.help-button {
cursor: pointer;
}

and

".help" : function(e) {
e.onclick = function()

{ // ... }

}

I tried using but could not get this to work; I could
get the page to display the help but then the browser would try to submit the
form action. Nor could I get a satisfactory result wrapping the in a

; not sure how to completely disable a from doing anything except
where told by onclick. Setting onsubmit for the form did not help; it still
tried to load a new page. One of those days I'm glad I'm not paid to write web
apps...


Originally reported by jglick, imported from: "Behavior" framework makes Hudson config page help buttons inaccessible
  • status: Closed
  • priority: Trivial
  • resolution: Fixed
  • resolved: 2006-08-17T21:05:50+00:00
  • imported: 2022/01/10
timja commented 18 years ago

super_kohsuke:

What if we put an tag around it?

timja commented 18 years ago

jglick:

tag would probably work but then you need to provide an href attr, which
would need to be a 'javascript'-protocol URI, which would not be using
hudson-behavior.js.

timja commented 18 years ago

kohsuke:

It could be just . The onclick event happens anyway, and we can
intercept it with our current mechanism.

Or we don't have to use behavior.js. We can href to javascript URL and call the
right function (create one if needed) with the right parameter. The only part
I'm not sure about is how to pass in the 'this' reference.

timja commented 18 years ago

jglick:

I'll try .

timja commented 18 years ago

jglick:

Created an attachment (id=15)
Failed patch

timja commented 18 years ago

jglick:

Does not work in Firefox 1.5; "Loading" appears but is not replaced with help text.

timja commented 18 years ago

kohsuke:

Almost. You needed to move helpURL attribute as well.
Fix committed. Thanks for the patch.