search

timja / jenkins-gh-issues-poc-06-18

0 stars 0 forks source link

[JENKINS-7222] Executors dead due to parenthesis in node name #890

Closed timja closed 14 years ago

timja commented 14 years ago

All our executors dies with the following stacktrace. We have a slave named "lucene.zones.apache.org (Solaris 10)", unknown if any job has assigned this as a label.

java.lang.IllegalArgumentException: Invalid label expression: lucene.zones.apache.org (Solaris 10)
at hudson.model.Hudson.getLabel(Hudson.java:1381)
at hudson.model.AbstractProject.getAssignedLabel(AbstractProject.java:288)
at hudson.model.Node.canTake(Node.java:242)
at hudson.model.Queue$JobOffer.canTake(Queue.java:190)
at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:818)
at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:810)
at hudson.model.Queue.pop(Queue.java:740)
at hudson.model.Executor.grabJob(Executor.java:165)
at hudson.model.Executor.run(Executor.java:106)
Caused by: line 1:25: unexpected token: (
at hudson.model.label.LabelExpressionParser.term4(LabelExpressionParser.java:170)
at hudson.model.label.LabelExpressionParser.term3(LabelExpressionParser.java:119)
at hudson.model.label.LabelExpressionParser.term2(LabelExpressionParser.java:89)
at hudson.model.label.LabelExpressionParser.term1(LabelExpressionParser.java:60)
at hudson.model.label.LabelExpressionParser.expr(LabelExpressionParser.java:50)
at hudson.model.Label.parseExpression(Label.java:458)
at hudson.model.Hudson.getLabel(Hudson.java:1379)
... 8 more

Originally reported by protocol7b, imported from: Executors dead due to parenthesis in node name
  • assignee: kohsuke
  • status: Resolved
  • priority: Critical
  • resolution: Duplicate
  • resolved: 2010-08-20T11:50:11+00:00
  • imported: 2022/01/10
timja commented 14 years ago

protocol7b:

Further investigation showed that we did indeed have a job that was tied to the the label name "lucene.zones.apache.org (Solaris 10)". This job was in the build queue when this happened. Fixing that and restarting our master resurrected the slaves. However, it seems a bit brutal to kill the executor threads due to this problem

timja commented 14 years ago

protocol7b:

I'm guessing this is due to the label configuration now taking a boolean expression. Most of our slaves have names containing parenthesis, which brakes in 1.372. Are node names containing parenthesis not allowed?

timja commented 14 years ago

kohsuke:

Fix to JENKINS-7216 should fix this, so I'm merging these two issues together.

timja commented 2 years ago

[Originally duplicated by: JENKINS-7216]